Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug dispatches for fetch + fallback exchanges #659

Merged
merged 4 commits into from Mar 23, 2020

Conversation

@andyrichardson
Copy link
Contributor

andyrichardson commented Mar 23, 2020

About

Add debug dispatches for key events in fetch and fallback exchanges

andyrichardson and others added 2 commits Mar 23, 2020
Co-authored-by: Will Golledge <wiggiumg@gmail.com>
Co-authored-by: Will Golledge <wiggiumg@gmail.com>
@changeset-bot

This comment has been minimized.

Copy link

changeset-bot bot commented Mar 23, 2020

💥 No Changeset

Latest commit: 69a8e09

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

packages/core/src/exchanges/dedup.ts Outdated Show resolved Hide resolved
packages/core/src/exchanges/fallback.ts Outdated Show resolved Hide resolved
packages/core/src/exchanges/fetch.ts Outdated Show resolved Hide resolved
.catch(err => {
if (err.name !== 'AbortError') {

This comment has been minimized.

Copy link
@JoviDeCroock

JoviDeCroock Mar 23, 2020

Member

let's keep this condition and just move dispatchEvent in here

@andyrichardson andyrichardson requested a review from JoviDeCroock Mar 23, 2020
@andyrichardson andyrichardson merged commit d9924b2 into add-event-support Mar 23, 2020
2 checks passed
2 checks passed
ci/codesandbox Building packages succeeded.
Details
stable Workflow: stable
Details
@andyrichardson andyrichardson deleted the add-event-dispatches branch Mar 23, 2020
wgolledge added a commit that referenced this pull request Mar 23, 2020
* Add debug dispatching for fetchExchange

Co-authored-by: Will Golledge <wiggiumg@gmail.com>

* Add fallback exchange debugEvent dispatch

Co-authored-by: Will Golledge <wiggiumg@gmail.com>

* Amend Jovis comments

* Fix fetch tests

Co-authored-by: Will Golledge <wiggiumg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.