Skip to content

Commit

Permalink
nits
Browse files Browse the repository at this point in the history
  • Loading branch information
boygirl committed Jul 16, 2018
1 parent 602738a commit 5a5e3cd
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 13 deletions.
7 changes: 2 additions & 5 deletions CONTRIBUTING.md
Expand Up @@ -109,17 +109,14 @@ Each package must contain the following version scripts and publishr config in i
Pre version checks are run _once_ for all packages, and are defined in the root directory `package.json`

```
"preversion": "nps check",
"preversion": "nps check"
```

The following commands will let you try a version without publishing or creating git commits:

```console
// This command bumps versions, runs checks, builds libs, and runs publishr postversion (~5 minutes)
nps lerna-dry-run

// Because postpublish will never run, it's necessary to manually clean up
nps global-postpublish
$ nps lerna-dry-run
```

## Contributor Covenant Code of Conduct
Expand Down
5 changes: 1 addition & 4 deletions config/webpack/demo/webpack.config.dev.js
Expand Up @@ -13,7 +13,7 @@ var WDS_PORT = 3000;
module.exports = {

devServer: {
port: parseInt(process.env.npm_package_config_wds_port_dev || WDS_PORT),
port: WDS_PORT,
contentBase: "./demo",
noInfo: false
},
Expand Down Expand Up @@ -42,9 +42,6 @@ module.exports = {
// Use include specifically of our sources.
// Do _not_ use an `exclude` here.
include: FILES.concat([DEMO]),
// **Note**: Cannot use shorthand `"babel-loader"` or `"babel"` when
// we are playing around with `NODE_PATH` in builder. Manually
// resolve path.
loader: "babel-loader"
}
]
Expand Down
3 changes: 0 additions & 3 deletions config/webpack/webpack.config.js
Expand Up @@ -58,9 +58,6 @@ module.exports = {
// Use include specifically of our sources.
// Do _not_ use an `exclude` here.
include: [SRC],
// **Note**: Cannot use shorthand `"babel-loader"` or `"babel"` when
// we are playing around with `NODE_PATH` in builder. Manually
// resolve path.
loader: require.resolve("babel-loader")
}
]
Expand Down
2 changes: 1 addition & 1 deletion config/webpack/webpack.config.test.js
Expand Up @@ -37,7 +37,7 @@ module.exports = {
},
devtool: "source-map",
devServer: {
port: parseInt(process.env.npm_package_config_wds_port_test || WDS_PORT),
port: WDS_PORT,
noInfo: false
}
};

0 comments on commit 5a5e3cd

Please sign in to comment.