-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize dependencies #201
Comments
The size requirements aren’t terrible when using
Some large parts:
|
I think 320mb and 3 minutes install time for one module (consisting of different components) is unacceptable! Especially since it would be so easy to fix by adding radium, d3-shape, victory-utils and victory-animations to your victory package directly, so it won't get installed and post-installed multiple times. Your other mentions could surely help reducing the time/size further. NPM3 installs dependencies in a flat way, so of course it will help. But lots of people still rely on NPM2. |
Maybe victory should depend on radium, d3-shape, victory-utils and victory-animations, as these libraries are currently installed in every single victory-xxx package inside victorys node_modules.
Installation was a real pain, as there is a big number of postinstalls executed.
Also, history is present in node_modules, I thought that it was put into devdependencies some time ago. Was this released to npm?
The text was updated successfully, but these errors were encountered: