New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutter not creating space between vertical legend rows #862

Closed
tacomanator opened this Issue Dec 1, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@tacomanator

tacomanator commented Dec 1, 2017

According to VictoryLegend docs:

When orientation is vertical, gutters are the space between rows.

Currently gutter space is applied between columns instead of rows, regardless of orientation. Can be reproduced on website using orientation vertical with large gutter:

<VictoryLegend x={125} y={50}
  orientation="vertical"
  gutter={300}
  style={{ border: { stroke: "black" } }}
  data={[{ name: "One" }, { name: "Two" }, { name: "Three" }]}
/>

legend

Great job on this library guys!

@ebrillhart

This comment has been minimized.

Show comment
Hide comment
@ebrillhart

ebrillhart Dec 1, 2017

Contributor

Seconding this!

Contributor

ebrillhart commented Dec 1, 2017

Seconding this!

@exogen

This comment has been minimized.

Show comment
Hide comment
@exogen

exogen Dec 4, 2017

Contributor

One additional TODO here is to update the docs

Contributor

exogen commented Dec 4, 2017

One additional TODO here is to update the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment