Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handles disappearing with `invertedAxis` #1434

Merged
merged 3 commits into from Nov 8, 2019

Conversation

@Hypnosphi
Copy link
Contributor

Hypnosphi commented Nov 5, 2019

This fixes #1432 by reusing BrushHelpers.getHandles

This also moves brushDimension checks to BrushHelpers.getHandles, to ensure that behaviour is consistent with cursors

@boygirl

This comment has been minimized.

Copy link
Member

boygirl commented Nov 7, 2019

@Hypnosphi Thanks for this fix! I just took a look locally, though, and noticed a small regression. The top and bottom handles seem to be slightly offset from the edge of the brush area. I'm guessing there's a missing negative sign when accounting for the handle width.

This should illustrate what I mean:
incorrect-y-brushes

Once that's fixed, this looks good to merge.

@boygirl

This comment has been minimized.

Copy link
Member

boygirl commented Nov 8, 2019

Thanks!

@boygirl boygirl merged commit 84e9583 into FormidableLabs:master Nov 8, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.