Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript: Mark data as readonly #2313

Merged
merged 1 commit into from Jun 20, 2022
Merged

Conversation

scottrippey
Copy link
Member

What

Marks data as readonly.
We don't mutate the data, so this doesn't break anything, and doesn't require any other changes.

Fixes #2309

Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@scottrippey scottrippey merged commit f434758 into main Jun 20, 2022
@scottrippey scottrippey deleted the typescript/readonly-data branch June 20, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript readonly data array is incompatible with data property interface definition
3 participants