New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSR issue with @forawesome/fontawesome 1.1.0 #11984

Closed
juhaelee opened this Issue Dec 22, 2017 · 7 comments

Comments

Projects
None yet
7 participants
@juhaelee

juhaelee commented Dec 22, 2017

I'm receiving the following error when trying to SSR with fontawesome:

Cannot read property 'doScroll' of undefined
as node_modules/@fortawesome/fontawesome/index.js:192:39

Looks like this line is being executed when DOCUMENT is undefined:

var loaded = (DOCUMENT.documentElement.doScroll ? /^loaded|^c/ : /^loaded|^i|^c/).test(DOCUMENT.readyState);

@robmadole

This comment has been minimized.

Show comment
Hide comment
@robmadole

robmadole Dec 23, 2017

Collaborator

Yep, I know what that is. My dumb mistake. I'll get to this quickly when we get back from holiday break.

Collaborator

robmadole commented Dec 23, 2017

Yep, I know what that is. My dumb mistake. I'll get to this quickly when we get back from holiday break.

erkkapynnonen added a commit to erkkapynnonen/melankolia-website that referenced this issue Dec 25, 2017

@toadkicker

This comment has been minimized.

Show comment
Hide comment
@toadkicker

toadkicker Dec 27, 2017

For nuxt users I just rolled back a version and things were rendering again:

    "@fortawesome/fontawesome": "=1.0.1",
    "@fortawesome/vue-fontawesome": "=0.0.21",

toadkicker commented Dec 27, 2017

For nuxt users I just rolled back a version and things were rendering again:

    "@fortawesome/fontawesome": "=1.0.1",
    "@fortawesome/vue-fontawesome": "=0.0.21",
@OriginalEXE

This comment has been minimized.

Show comment
Hide comment
@OriginalEXE

OriginalEXE Jan 14, 2018

Is there any chance that you could prioritize this?

OriginalEXE commented Jan 14, 2018

Is there any chance that you could prioritize this?

@eduludi

This comment has been minimized.

Show comment
Hide comment
@eduludi

eduludi Jan 15, 2018

There is also a DOCUMENT.documentElement.classList in node_modules/@fortawesome/fontawesome/index.js:1335 that mess SSR

eduludi commented Jan 15, 2018

There is also a DOCUMENT.documentElement.classList in node_modules/@fortawesome/fontawesome/index.js:1335 that mess SSR

@ezekielloves

This comment has been minimized.

Show comment
Hide comment
@ezekielloves

ezekielloves Jan 24, 2018

Is this the reason why fontawesome 5 icons are not rendering on VueJs?

ezekielloves commented Jan 24, 2018

Is this the reason why fontawesome 5 icons are not rendering on VueJs?

@robmadole

This comment has been minimized.

Show comment
Hide comment
@robmadole

robmadole Jan 25, 2018

Collaborator

We'll be releasing some fixes for SSR hopefully today.

Collaborator

robmadole commented Jan 25, 2018

We'll be releasing some fixes for SSR hopefully today.

@robmadole

This comment has been minimized.

Show comment
Hide comment
@robmadole

robmadole Jan 27, 2018

Collaborator

1.1.3 should take care of all the SSR issues. Please let me know if you run into any more troubles.

Collaborator

robmadole commented Jan 27, 2018

1.1.3 should take care of all the SSR issues. Please let me know if you run into any more troubles.

@robmadole robmadole closed this Jan 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment