Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Brand Icons (Ad blockers related issue) #1799

Closed
eridal opened this issue Aug 18, 2013 · 71 comments
Closed

Missing Brand Icons (Ad blockers related issue) #1799

eridal opened this issue Aug 18, 2013 · 71 comments
Labels
bug
Milestone

Comments

@eridal
Copy link

@eridal eridal commented Aug 18, 2013

Hi all,
I've noted that some brand icons are missing: fb, g+, linkedin, pinterest, and twitter specially.

Here is how it looks like in my browser.
screenshot from 2013-08-18 06 15 47

@tagliala
Copy link
Member

@tagliala tagliala commented Aug 18, 2013

browser? os? (looks like chrome/w7)

Please clear your browser cache and check that you have not installed an old version of the fontawesome ttf in your system.

Check other browsers too

@eridal
Copy link
Author

@eridal eridal commented Aug 18, 2013

Firefox 23.0 on Ubuntu 12.04

@tagliala
Copy link
Member

@tagliala tagliala commented Aug 18, 2013

Could you please test other browsers and clear the cache?

@ghost
Copy link

@ghost ghost commented Aug 19, 2013

just ran into this issue, and wanted to comment
I'm running Ubuntu 13.04 and FF 23 and everything looks fine.
And in fact I don't think that Ubuntu version does something here, probably your cashe needs to be cleaned IMHO )

@eridal
Copy link
Author

@eridal eridal commented Aug 20, 2013

I'm not sure why but I keeps failing. I have clean cache and even disabled it but they are still missing.

@tagliala
Copy link
Member

@tagliala tagliala commented Aug 21, 2013

Other browsers?

@eridal
Copy link
Author

@eridal eridal commented Aug 22, 2013

Hmm it only fails, persistently, on Firefox. I works just fine on others.
Well.. I hope this is only broken on my machine.

@eridal eridal closed this Aug 22, 2013
@tagliala
Copy link
Member

@tagliala tagliala commented Aug 22, 2013

Everything is fine for me on Firefox/Ubuntu 13.04.

If I well remember, there was an issue with Firefox and older version of Ubuntu due to graphic drivers...

@deepakprabhakara
Copy link

@deepakprabhakara deepakprabhakara commented Sep 8, 2013

I noticed that the same issue has surfaced in Chrome's latest version (v 29.0.1547.65), works fine in the older versions. Looks like Google broke something in their latest version.

@tagliala
Copy link
Member

@tagliala tagliala commented Sep 8, 2013

can you please check graphic drivers?

@deepakprabhakara
Copy link

@deepakprabhakara deepakprabhakara commented Sep 8, 2013

@tagliala This is on Macbook Air (OS X 10.8.4), Intel HD Graphics 4000. As far as I remember I haven't updating anything related to the graphics card.

@deepakprabhakara
Copy link

@deepakprabhakara deepakprabhakara commented Sep 8, 2013

@tagliala Damn! Found the culprit, it's https://adblockplus.org Chrome extension. It blocks anything remotely containing these social network keywords!

@eridal Could you please check to see if you have Adblock Plus or a similar ad blocker installed on Firefox?

@tagliala
Copy link
Member

@tagliala tagliala commented Sep 8, 2013

@deepakprabhakara is that a default?

@tagliala
Copy link
Member

@tagliala tagliala commented Sep 8, 2013

@deepakprabhakara confirming it's not a default.

It depends on "Remove Social Media Buttons" option:

.icon-twitter, .iconFacebook, .iconTwitter, .icon_delicious, .icon_digg, .icon_facebook, .icon_twitter, .icos-social, .idMetaItmSocialCompact, .idc-share, .identity-fb-notice, .ilsb-share, .in-post-social, .in-social, .inarticle-image-share, .inline-img-share-fb-button, .inline-img-share-tw-button, .inline-share, .inline_socials, .inner-social {
display: none;
}

.horiz_share, .horizontal-share-buttons, .horizontal-social-links, .hp-ss-share, .huge-share-box, .icn-addthis, .icn-share, .icn-twit, .ico-social, .ico-twitter, .ico-vkontakte, .icoFacebookBig, .icon-facebook, .icon-google-plus, .icon-googleplus, .icon-gplus, .icon-linkedin, .icon-pinterest, .icon-plusone, .icon-social {
display: none;
}

...

useless imho, malicious websites can change classes... I don't know what to say.

Can you please contact their support and ask them?

edit: the list causing this issue is "Fanboy's Social Blocking List"

@tagliala tagliala reopened this Sep 8, 2013
@tagliala
Copy link
Member

@tagliala tagliala commented Sep 8, 2013

reopened just for tracking purposes. We can document it but it's not fontawesome's fault

@deepakprabhakara
Copy link

@deepakprabhakara deepakprabhakara commented Sep 8, 2013

I have reported the issue on their forum. Will report back if I hear anything.

@davegandy
Copy link
Member

@davegandy davegandy commented Sep 17, 2013

Yeah, this is a good issue to track.

Freaking AdBlock. Hope folks are aware of their business model. If your Ad company is willing to pay them, they'll let your ads through. This is basically extortion in my book.

@deepakprabhakara
Copy link

@deepakprabhakara deepakprabhakara commented Sep 24, 2013

Yeah but I doubt AdBlock will even bother looking at this. I posted on their forum and the response was to "Turn off social list". I have worked around the issue in my project by redefining the affected icons with a different name.

@greyshi
Copy link

@greyshi greyshi commented Oct 16, 2013

There is no contact information on the list's page. Is the list subscribed to by default when installing adblock plus? I think it has been for me.

@tagliala
Copy link
Member

@tagliala tagliala commented Jan 16, 2014

Closing this one, #2747 is about docs

@ExpertUser
Copy link

@ExpertUser ExpertUser commented Aug 23, 2018

Today I got css files of stackoverflow.com blocked by adblock :(
Moreover, few other sites have similar problem of loading.
Fontawesome are being blocked too

@qumberrizvi
Copy link

@qumberrizvi qumberrizvi commented Sep 13, 2018

I have seen instances of googlefontapi being blocked by AdGuard. As soon as AdGuard detects any third-party CSS being used on a webpage, the adblocker blocks it.

screenshot 19
screenshot 20

@tagliala tagliala changed the title Missing Brand Icons (Adblock Plus related issue) Missing Brand Icons (Ad blockers related issue) Dec 18, 2018
@GiacomoLaw
Copy link

@GiacomoLaw GiacomoLaw commented Jan 26, 2019

How can I stop them from being blocked? Just redefine the names?

@tagliala
Copy link
Member

@tagliala tagliala commented Mar 19, 2019

How can I stop them from being blocked? Just redefine the names?

That would work

@jessuppi
Copy link

@jessuppi jessuppi commented May 9, 2019

+1 that linkedin-in icon is currently being blocked again by Adblock (Chrome extension)

For some reason, most other social icons seem fine at this time.

Why are non-tracking icons still being blocked by Adblock? No relation to social tracking... millions of users can't be expected to install custom lists just to make icons appear properly.

@tagliala
Copy link
Member

@tagliala tagliala commented May 9, 2019

Why are non-tracking icons still being blocked by Adblock?

Please report the issue to the offending list, explaining that the icon itself has no impact on user's privacy.

millions of users can't be expected to install custom lists just to make icons appear properly.

In a broader sense, if "no social" lists are supposed to block "any social network related content" and the user deliberately opted-in for this feature, blocking lists are working as intended

@Burnett01
Copy link

@Burnett01 Burnett01 commented Jan 16, 2020

Renaming seems to be the only option for now. At least this is what we end up doing.
We don't want to rely on AdBlock's list.

bric3 added a commit to bric3/bric3.github.io that referenced this issue Apr 14, 2020
1. Download the SVG from fontawesome to assets folder, e.g
    https://fontawesome.com/icons/linkedin-in?style=brands
2. Replace the HTML element by the inline svg with the template
    `{{- readFile "/assets/icons/linkedin-brands.svg" | replaceRE "linkedin" "pro-network" | safeHTML -}}`

Related to this issue: FortAwesome/Font-Awesome#1799
@FortAwesome FortAwesome deleted a comment from Berok67 Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet