Missing Brand Icons (Adblock Plus related issue) #1799

Closed
eridal opened this Issue Aug 18, 2013 · 64 comments

Comments

Projects
None yet
@eridal

eridal commented Aug 18, 2013

Hi all,
I've noted that some brand icons are missing: fb, g+, linkedin, pinterest, and twitter specially.

Here is how it looks like in my browser.
screenshot from 2013-08-18 06 15 47

@tagliala

This comment has been minimized.

Show comment
Hide comment
@tagliala

tagliala Aug 18, 2013

Member

browser? os? (looks like chrome/w7)

Please clear your browser cache and check that you have not installed an old version of the fontawesome ttf in your system.

Check other browsers too

Member

tagliala commented Aug 18, 2013

browser? os? (looks like chrome/w7)

Please clear your browser cache and check that you have not installed an old version of the fontawesome ttf in your system.

Check other browsers too

@eridal

This comment has been minimized.

Show comment
Hide comment
@eridal

eridal Aug 18, 2013

Firefox 23.0 on Ubuntu 12.04

eridal commented Aug 18, 2013

Firefox 23.0 on Ubuntu 12.04

@tagliala

This comment has been minimized.

Show comment
Hide comment
@tagliala

tagliala Aug 18, 2013

Member

Could you please test other browsers and clear the cache?

Member

tagliala commented Aug 18, 2013

Could you please test other browsers and clear the cache?

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Aug 19, 2013

just ran into this issue, and wanted to comment
I'm running Ubuntu 13.04 and FF 23 and everything looks fine.
And in fact I don't think that Ubuntu version does something here, probably your cashe needs to be cleaned IMHO )

ghost commented Aug 19, 2013

just ran into this issue, and wanted to comment
I'm running Ubuntu 13.04 and FF 23 and everything looks fine.
And in fact I don't think that Ubuntu version does something here, probably your cashe needs to be cleaned IMHO )

@eridal

This comment has been minimized.

Show comment
Hide comment
@eridal

eridal Aug 20, 2013

I'm not sure why but I keeps failing. I have clean cache and even disabled it but they are still missing.

eridal commented Aug 20, 2013

I'm not sure why but I keeps failing. I have clean cache and even disabled it but they are still missing.

@tagliala

This comment has been minimized.

Show comment
Hide comment
@tagliala

tagliala Aug 21, 2013

Member

Other browsers?

Member

tagliala commented Aug 21, 2013

Other browsers?

@eridal

This comment has been minimized.

Show comment
Hide comment
@eridal

eridal Aug 22, 2013

Hmm it only fails, persistently, on Firefox. I works just fine on others.
Well.. I hope this is only broken on my machine.

eridal commented Aug 22, 2013

Hmm it only fails, persistently, on Firefox. I works just fine on others.
Well.. I hope this is only broken on my machine.

@eridal eridal closed this Aug 22, 2013

@tagliala

This comment has been minimized.

Show comment
Hide comment
@tagliala

tagliala Aug 22, 2013

Member

Everything is fine for me on Firefox/Ubuntu 13.04.

If I well remember, there was an issue with Firefox and older version of Ubuntu due to graphic drivers...

Member

tagliala commented Aug 22, 2013

Everything is fine for me on Firefox/Ubuntu 13.04.

If I well remember, there was an issue with Firefox and older version of Ubuntu due to graphic drivers...

@deepakprabhakara

This comment has been minimized.

Show comment
Hide comment
@deepakprabhakara

deepakprabhakara Sep 8, 2013

I noticed that the same issue has surfaced in Chrome's latest version (v 29.0.1547.65), works fine in the older versions. Looks like Google broke something in their latest version.

I noticed that the same issue has surfaced in Chrome's latest version (v 29.0.1547.65), works fine in the older versions. Looks like Google broke something in their latest version.

@tagliala

This comment has been minimized.

Show comment
Hide comment
@tagliala

tagliala Sep 8, 2013

Member

can you please check graphic drivers?

Member

tagliala commented Sep 8, 2013

can you please check graphic drivers?

@deepakprabhakara

This comment has been minimized.

Show comment
Hide comment
@deepakprabhakara

deepakprabhakara Sep 8, 2013

@tagliala This is on Macbook Air (OS X 10.8.4), Intel HD Graphics 4000. As far as I remember I haven't updating anything related to the graphics card.

@tagliala This is on Macbook Air (OS X 10.8.4), Intel HD Graphics 4000. As far as I remember I haven't updating anything related to the graphics card.

@deepakprabhakara

This comment has been minimized.

Show comment
Hide comment
@deepakprabhakara

deepakprabhakara Sep 8, 2013

@tagliala Damn! Found the culprit, it's https://adblockplus.org Chrome extension. It blocks anything remotely containing these social network keywords!

@eridal Could you please check to see if you have Adblock Plus or a similar ad blocker installed on Firefox?

@tagliala Damn! Found the culprit, it's https://adblockplus.org Chrome extension. It blocks anything remotely containing these social network keywords!

@eridal Could you please check to see if you have Adblock Plus or a similar ad blocker installed on Firefox?

@tagliala

This comment has been minimized.

Show comment
Hide comment
@tagliala

tagliala Sep 8, 2013

Member

@deepakprabhakara is that a default?

Member

tagliala commented Sep 8, 2013

@deepakprabhakara is that a default?

@tagliala

This comment has been minimized.

Show comment
Hide comment
@tagliala

tagliala Sep 8, 2013

Member

@deepakprabhakara confirming it's not a default.

It depends on "Remove Social Media Buttons" option:

.icon-twitter, .iconFacebook, .iconTwitter, .icon_delicious, .icon_digg, .icon_facebook, .icon_twitter, .icos-social, .idMetaItmSocialCompact, .idc-share, .identity-fb-notice, .ilsb-share, .in-post-social, .in-social, .inarticle-image-share, .inline-img-share-fb-button, .inline-img-share-tw-button, .inline-share, .inline_socials, .inner-social {
display: none;
}

.horiz_share, .horizontal-share-buttons, .horizontal-social-links, .hp-ss-share, .huge-share-box, .icn-addthis, .icn-share, .icn-twit, .ico-social, .ico-twitter, .ico-vkontakte, .icoFacebookBig, .icon-facebook, .icon-google-plus, .icon-googleplus, .icon-gplus, .icon-linkedin, .icon-pinterest, .icon-plusone, .icon-social {
display: none;
}

...

useless imho, malicious websites can change classes... I don't know what to say.

Can you please contact their support and ask them?

edit: the list causing this issue is "Fanboy's Social Blocking List"

Member

tagliala commented Sep 8, 2013

@deepakprabhakara confirming it's not a default.

It depends on "Remove Social Media Buttons" option:

.icon-twitter, .iconFacebook, .iconTwitter, .icon_delicious, .icon_digg, .icon_facebook, .icon_twitter, .icos-social, .idMetaItmSocialCompact, .idc-share, .identity-fb-notice, .ilsb-share, .in-post-social, .in-social, .inarticle-image-share, .inline-img-share-fb-button, .inline-img-share-tw-button, .inline-share, .inline_socials, .inner-social {
display: none;
}

.horiz_share, .horizontal-share-buttons, .horizontal-social-links, .hp-ss-share, .huge-share-box, .icn-addthis, .icn-share, .icn-twit, .ico-social, .ico-twitter, .ico-vkontakte, .icoFacebookBig, .icon-facebook, .icon-google-plus, .icon-googleplus, .icon-gplus, .icon-linkedin, .icon-pinterest, .icon-plusone, .icon-social {
display: none;
}

...

useless imho, malicious websites can change classes... I don't know what to say.

Can you please contact their support and ask them?

edit: the list causing this issue is "Fanboy's Social Blocking List"

@tagliala tagliala reopened this Sep 8, 2013

@tagliala

This comment has been minimized.

Show comment
Hide comment
@tagliala

tagliala Sep 8, 2013

Member

reopened just for tracking purposes. We can document it but it's not fontawesome's fault

Member

tagliala commented Sep 8, 2013

reopened just for tracking purposes. We can document it but it's not fontawesome's fault

@deepakprabhakara

This comment has been minimized.

Show comment
Hide comment
@deepakprabhakara

deepakprabhakara Sep 8, 2013

I have reported the issue on their forum. Will report back if I hear anything.

I have reported the issue on their forum. Will report back if I hear anything.

@davegandy

This comment has been minimized.

Show comment
Hide comment
@davegandy

davegandy Sep 17, 2013

Member

Yeah, this is a good issue to track.

Freaking AdBlock. Hope folks are aware of their business model. If your Ad company is willing to pay them, they'll let your ads through. This is basically extortion in my book.

Member

davegandy commented Sep 17, 2013

Yeah, this is a good issue to track.

Freaking AdBlock. Hope folks are aware of their business model. If your Ad company is willing to pay them, they'll let your ads through. This is basically extortion in my book.

@deepakprabhakara

This comment has been minimized.

Show comment
Hide comment
@deepakprabhakara

deepakprabhakara Sep 24, 2013

Yeah but I doubt AdBlock will even bother looking at this. I posted on their forum and the response was to "Turn off social list". I have worked around the issue in my project by redefining the affected icons with a different name.

Yeah but I doubt AdBlock will even bother looking at this. I posted on their forum and the response was to "Turn off social list". I have worked around the issue in my project by redefining the affected icons with a different name.

@greyshi

This comment has been minimized.

Show comment
Hide comment
@greyshi

greyshi Oct 16, 2013

There is no contact information on the list's page. Is the list subscribed to by default when installing adblock plus? I think it has been for me.

greyshi commented Oct 16, 2013

There is no contact information on the list's page. Is the list subscribed to by default when installing adblock plus? I think it has been for me.

@tagliala

This comment has been minimized.

Show comment
Hide comment
@tagliala

tagliala Jan 16, 2014

Member

Closing this one, #2747 is about docs

Member

tagliala commented Jan 16, 2014

Closing this one, #2747 is about docs

@ehcloninger

This comment has been minimized.

Show comment
Hide comment
@ehcloninger

ehcloninger Mar 6, 2014

I was bit by this today. I agree the issue is with using AdBlock and not sure what can be done for it. Perhaps an alternate name for the items that are obfuscated. Seems like it would be a never-ending escalation, though.

At the very least, could you add another item to https://github.com/FortAwesome/Font-Awesome/wiki/Troubleshooting that says "Are you using AdBlock?"

I was bit by this today. I agree the issue is with using AdBlock and not sure what can be done for it. Perhaps an alternate name for the items that are obfuscated. Seems like it would be a never-ending escalation, though.

At the very least, could you add another item to https://github.com/FortAwesome/Font-Awesome/wiki/Troubleshooting that says "Are you using AdBlock?"

@tagliala

This comment has been minimized.

Show comment
Hide comment
@tagliala

tagliala Mar 7, 2014

Member

@ehcloninger thanks, added. feel free to edit that wiki I'm non native English speaker

Member

tagliala commented Mar 7, 2014

@ehcloninger thanks, added. feel free to edit that wiki I'm non native English speaker

@davegandy

This comment has been minimized.

Show comment
Hide comment
@davegandy

davegandy May 13, 2014

Member

Interesting. I'm no longer seeing this behavior for Adblock or Adblock Plus (those aren't confusing names at all for different products).

Member

davegandy commented May 13, 2014

Interesting. I'm no longer seeing this behavior for Adblock or Adblock Plus (those aren't confusing names at all for different products).

@tagliala

This comment has been minimized.

Show comment
Hide comment
@tagliala

tagliala May 13, 2014

Member

@davegandy I confirm this is still an issue.

During the first run, you will be asked if you want to enable the "Remove Social Media Buttons" options. If you enable that, no (very popular) social icons

image

Member

tagliala commented May 13, 2014

@davegandy I confirm this is still an issue.

During the first run, you will be asked if you want to enable the "Remove Social Media Buttons" options. If you enable that, no (very popular) social icons

image

@garrett garrett referenced this issue in ManageIQ/manageiq.org Jun 30, 2014

Merged

Work-around AdBlock #127

@uxmoon

This comment has been minimized.

Show comment
Hide comment
@uxmoon

uxmoon Jul 16, 2014

I had to use fontello.com, select only the necessary icons for my site and customize the facebook icon name under "Customize names" and it did the trick.
I only need 10 icons for my website.

uxmoon commented Jul 16, 2014

I had to use fontello.com, select only the necessary icons for my site and customize the facebook icon name under "Customize names" and it did the trick.
I only need 10 icons for my website.

cmoel added a commit to cmoel/cmoel.com that referenced this issue Dec 1, 2015

Fix font awesome Twitter icon not displaying in Safari
According to this issue:
FortAwesome/Font-Awesome#1799 (comment)

This appears to be an issue with AdBlock Plus. Changing the prefix makes
it work

cmoel added a commit to cmoel/cmoel.com that referenced this issue Dec 1, 2015

Fix font awesome Twitter icon not displaying in Safari
According to this issue:
FortAwesome/Font-Awesome#1799 (comment)

This appears to be an issue with AdBlock Plus. Changing the prefix makes
it work
@cydrobolt

This comment has been minimized.

Show comment
Hide comment
@cydrobolt

cydrobolt Feb 27, 2016

Disabling "fanboy's annoyances" fixed the issue for me.

Disabling "fanboy's annoyances" fixed the issue for me.

@david-w david-w referenced this issue in david-w/david-w.github.io May 5, 2016

Closed

Font-Awesome social icons blocked by Adblock Plus #1

@yscoder yscoder referenced this issue in yscoder/hexo-theme-indigo May 13, 2016

Closed

好多图标不能显示 #26

@caleyshemc caleyshemc referenced this issue in caleyshemc/caleyshemc.github.io Jul 7, 2016

Closed

Font Awesome brand icons blocked by Adblock Plus #1

@mmistakes mmistakes referenced this issue in mmistakes/minimal-mistakes Aug 3, 2016

Closed

Author profile does not show links #413

3 of 4 tasks complete
@EmilMoe

This comment has been minimized.

Show comment
Hide comment
@EmilMoe

EmilMoe Aug 9, 2016

Sorry for picking it up again, but this is still not fixed. It's a simple matter of a renaming, so could we get an alias for all the social icons?

EmilMoe commented Aug 9, 2016

Sorry for picking it up again, but this is still not fixed. It's a simple matter of a renaming, so could we get an alias for all the social icons?

@rinopo

This comment has been minimized.

Show comment
Hide comment
@rinopo

rinopo Aug 9, 2016

@EmilMoe
Any aliases can be systematically blocked once they are systematically provided.
I'd recommend defining your own aliases as suggested in the previous comments:

#1799 (comment)
#1799 (comment)

rinopo commented Aug 9, 2016

@EmilMoe
Any aliases can be systematically blocked once they are systematically provided.
I'd recommend defining your own aliases as suggested in the previous comments:

#1799 (comment)
#1799 (comment)

@EmilMoe

This comment has been minimized.

Show comment
Hide comment
@EmilMoe

EmilMoe Aug 9, 2016

Perfect - Thanks, @rinopo

EmilMoe commented Aug 9, 2016

Perfect - Thanks, @rinopo

@mmistakes mmistakes referenced this issue in mmistakes/minimal-mistakes Aug 9, 2016

Closed

Author social buttons not showing up #421

3 of 5 tasks complete

@ThanosFisherman ThanosFisherman referenced this issue in codeasashu/hcz-jekyll-blog Sep 3, 2016

Closed

Social icons won't show up #23

@rhanajoy

This comment has been minimized.

Show comment
Hide comment
@rhanajoy

rhanajoy Sep 9, 2016

Hi! I'm the Community Manager for AdBlock. For the record, Adblock Plus (ABP), our friendly rival, is the company that maintains the Acceptable Ads program, not us. (Why the names are so similar is an interesting bit of Internet history trivia.)

I've written an article for our Knowledge Base that attempts to summarize the workarounds suggested here: AdBlock blocks Font Awesome social media icons.

Rhana
AdBlock Community Manager

rhanajoy commented Sep 9, 2016

Hi! I'm the Community Manager for AdBlock. For the record, Adblock Plus (ABP), our friendly rival, is the company that maintains the Acceptable Ads program, not us. (Why the names are so similar is an interesting bit of Internet history trivia.)

I've written an article for our Knowledge Base that attempts to summarize the workarounds suggested here: AdBlock blocks Font Awesome social media icons.

Rhana
AdBlock Community Manager

@Akronix

This comment has been minimized.

Show comment
Hide comment
@Akronix

Akronix Sep 13, 2016

Hi!
I'm experiencing this issue using bulma. Is there any way to show an alternative text in case adblock blocks the icon?
For example, we could use the unicode for the icons in case AdBlock is blocking the font-awesome code.

Akronix commented Sep 13, 2016

Hi!
I'm experiencing this issue using bulma. Is there any way to show an alternative text in case adblock blocks the icon?
For example, we could use the unicode for the icons in case AdBlock is blocking the font-awesome code.

@Paulmicha

This comment has been minimized.

Show comment
Hide comment
@Paulmicha

Paulmicha Sep 14, 2016

@rhanajoy How about fixing the defaults of the extension itself, instead of having everyone to fix it via settings ?

Because, arguably, things like external links to sites' facebook pages, often using these icons, do not qualify as ads. Same goes for the icons themselves (CSS or SVG) - different than typical ad techs like iframes or JS tracking.

This looks like an AdBlock issue, which could perhaps consider not including these particular lists in the first place.

@rhanajoy How about fixing the defaults of the extension itself, instead of having everyone to fix it via settings ?

Because, arguably, things like external links to sites' facebook pages, often using these icons, do not qualify as ads. Same goes for the icons themselves (CSS or SVG) - different than typical ad techs like iframes or JS tracking.

This looks like an AdBlock issue, which could perhaps consider not including these particular lists in the first place.

@rhanajoy

This comment has been minimized.

Show comment
Hide comment
@rhanajoy

rhanajoy Sep 14, 2016

@Paulmicha AdBlock currently subscribes users to four filter lists by default: EasyList, the primary list of ad-blocking filters that all ad blockers use; AdBlock Custom, which cleans up a few troublesome filters from EasyList and other filters that break specific sites, and adds blocks for ad providers EasyList doesn't care about; Acceptable Ads, which blocks intrusive, annoying ads while allowing ads that promise to be good (how faithfully some ads adhere to the AA guidelines is up for debate); and the Adblock Warning Removal list, which prevents you from seeing warnings to disable your ad blocker on some sites.

We also include some lists that are available by selection but are not enabled by default. Among them is Fanboy's Annoyances, which includes Fanboy's Social list. That's the one that's causing trouble with Font Awesome's social media icons.

Finally, users can subscribe to any list they like if they know its URL.

All of the above is true for ABP as well, with some slight differences.

So you see there really isn't any way we can prevent this on the extension side. It's a filter list issue, and we don't maintain the filter lists. I wish we could help! It would make things easier for our users, which is my chief concern.

@Paulmicha AdBlock currently subscribes users to four filter lists by default: EasyList, the primary list of ad-blocking filters that all ad blockers use; AdBlock Custom, which cleans up a few troublesome filters from EasyList and other filters that break specific sites, and adds blocks for ad providers EasyList doesn't care about; Acceptable Ads, which blocks intrusive, annoying ads while allowing ads that promise to be good (how faithfully some ads adhere to the AA guidelines is up for debate); and the Adblock Warning Removal list, which prevents you from seeing warnings to disable your ad blocker on some sites.

We also include some lists that are available by selection but are not enabled by default. Among them is Fanboy's Annoyances, which includes Fanboy's Social list. That's the one that's causing trouble with Font Awesome's social media icons.

Finally, users can subscribe to any list they like if they know its URL.

All of the above is true for ABP as well, with some slight differences.

So you see there really isn't any way we can prevent this on the extension side. It's a filter list issue, and we don't maintain the filter lists. I wish we could help! It would make things easier for our users, which is my chief concern.

@ThomasGreiner

This comment has been minimized.

Show comment
Hide comment
@ThomasGreiner

ThomasGreiner Sep 14, 2016

This looks like an AdBlock issue, which could perhaps consider not including these particular lists in the first place.

As @rhanajoy pointed out, such lists are not included by default in AdBlock or Adblock Plus. Also, as mentioned in my previous comment, I'd suggest discussing the scope of this particular filter list with the EasyList team or alternatively reporting individual issues using the issue reporter in Adblock Plus for Firefox.

What Adblock Plus does is recommend certain filter lists by providing its users the ability to easily enable popular features. So if there's a well-maintained filter list that blocks social media elements without breaking unrelated stuff, feel free to suggest it to be used for the "Remove social media buttons" feature.

This looks like an AdBlock issue, which could perhaps consider not including these particular lists in the first place.

As @rhanajoy pointed out, such lists are not included by default in AdBlock or Adblock Plus. Also, as mentioned in my previous comment, I'd suggest discussing the scope of this particular filter list with the EasyList team or alternatively reporting individual issues using the issue reporter in Adblock Plus for Firefox.

What Adblock Plus does is recommend certain filter lists by providing its users the ability to easily enable popular features. So if there's a well-maintained filter list that blocks social media elements without breaking unrelated stuff, feel free to suggest it to be used for the "Remove social media buttons" feature.

@Paulmicha

This comment has been minimized.

Show comment
Hide comment
@Paulmicha

Paulmicha Sep 14, 2016

such lists are not included by default in AdBlock or Adblock Plus

Then I must have added them in the past (though I don't remember doing that, but it's possible, as I've been using this extension for years now).

So by default, this issue shouldn't happen for users who haven't touched the extension settings then.
Thanks for the feedback !

such lists are not included by default in AdBlock or Adblock Plus

Then I must have added them in the past (though I don't remember doing that, but it's possible, as I've been using this extension for years now).

So by default, this issue shouldn't happen for users who haven't touched the extension settings then.
Thanks for the feedback !

@tagliala

This comment has been minimized.

Show comment
Hide comment
@tagliala

tagliala Sep 15, 2016

Member

such lists are not included by default in AdBlock or Adblock Plus

Then I must have added them in the past (though I don't remember doing that, but it's possible, as I've been using this extension for years now).

Not a default, but IIRC it was extremely easy to enable that option: #1799 (comment)

Member

tagliala commented Sep 15, 2016

such lists are not included by default in AdBlock or Adblock Plus

Then I must have added them in the past (though I don't remember doing that, but it's possible, as I've been using this extension for years now).

Not a default, but IIRC it was extremely easy to enable that option: #1799 (comment)

@ThomasGreiner

This comment has been minimized.

Show comment
Hide comment
@ThomasGreiner

ThomasGreiner Sep 15, 2016

Not a default, but IIRC it was extremely easy to enable that option: #1799 (comment)

Adblock Plus exposes that option only on the page that comes up right after successful installation. Recently, we removed that section from that page though (see https://issues.adblockplus.org/ticket/4294).

The plan is, however, to reintroduce it later on as part of the extension's settings page. For that we're planning to use the following text:

Disable Social Media Buttons

Adblock Plus can disable social media buttons on websites, ensuring that social networks can’t create a profile based on the websites you visit.

Buttons used to share content on social media platforms such as Facebook, Twitter, Google Plus and others are placed on almost every website that you visit. Even if you don't click them, these buttons send requests to the servers of the social network which use information to create a profile based on your browsing habits.

If you think that this text should be changed, I created an issue on our issue tracker for discussing those (see https://issues.adblockplus.org/ticket/4434).

Not a default, but IIRC it was extremely easy to enable that option: #1799 (comment)

Adblock Plus exposes that option only on the page that comes up right after successful installation. Recently, we removed that section from that page though (see https://issues.adblockplus.org/ticket/4294).

The plan is, however, to reintroduce it later on as part of the extension's settings page. For that we're planning to use the following text:

Disable Social Media Buttons

Adblock Plus can disable social media buttons on websites, ensuring that social networks can’t create a profile based on the websites you visit.

Buttons used to share content on social media platforms such as Facebook, Twitter, Google Plus and others are placed on almost every website that you visit. Even if you don't click them, these buttons send requests to the servers of the social network which use information to create a profile based on your browsing habits.

If you think that this text should be changed, I created an issue on our issue tracker for discussing those (see https://issues.adblockplus.org/ticket/4434).

@rhanajoy

This comment has been minimized.

Show comment
Hide comment
@rhanajoy

rhanajoy Sep 15, 2016

Wow. I blush to admit that I never knew those buttons did that. Now it makes more sense to me why the Social list would block them.

Wow. I blush to admit that I never knew those buttons did that. Now it makes more sense to me why the Social list would block them.

@gameguy43

This comment has been minimized.

Show comment
Hide comment
@gameguy43

gameguy43 Sep 15, 2016

@ThomasGreiner replying in that ticket now

@ThomasGreiner replying in that ticket now

@gameguy43

This comment has been minimized.

Show comment
Hide comment
@gameguy43

gameguy43 Sep 15, 2016

@rhanajoy, they don't do that, necessarily. Only the official widgets that use JS/iframes track you.

Which if you're using fontawesome, you're probably building your own buttons, which don't track people. But you're blocked anyway.

And that's the whole issue here. Non-tracking buttons are being broken by a block list that sells itself as blocking tracking buttons only.

Worse: it's blocking login buttons. Which are not tracking. And are not social sharing buttons. So they're entirely out of the scope of what the block list sells.

For a website like mine, where social login is the only way to log in, this block list fundamentally breaks the entire website.

The current copy and @ThomasGreiner's new copy do not make it clear to users that enabling this list may disable their ability to log in to websites. Log in is not mentioned.

@rhanajoy, they don't do that, necessarily. Only the official widgets that use JS/iframes track you.

Which if you're using fontawesome, you're probably building your own buttons, which don't track people. But you're blocked anyway.

And that's the whole issue here. Non-tracking buttons are being broken by a block list that sells itself as blocking tracking buttons only.

Worse: it's blocking login buttons. Which are not tracking. And are not social sharing buttons. So they're entirely out of the scope of what the block list sells.

For a website like mine, where social login is the only way to log in, this block list fundamentally breaks the entire website.

The current copy and @ThomasGreiner's new copy do not make it clear to users that enabling this list may disable their ability to log in to websites. Log in is not mentioned.

@rhanajoy

This comment has been minimized.

Show comment
Hide comment
@rhanajoy

rhanajoy Sep 16, 2016

@gameguy43 Thanks for clarifying that. Well, we can at least revise our descriptions of the Social list to mention this. I'll do that now in our KB and will create an issue to see whether we can change the description in the extension, too.

@gameguy43 Thanks for clarifying that. Well, we can at least revise our descriptions of the Social list to mention this. I'll do that now in our KB and will create an issue to see whether we can change the description in the extension, too.

@ryanbr

This comment has been minimized.

Show comment
Hide comment
@ryanbr

ryanbr Sep 19, 2016

Okay, didn't relise there was another open ticket..

From: ​https://lipis.github.io/bootstrap-social/


  <a class="btn btn-social-icon btn-twitter">
    <span class="fa fa-twitter"></span>
  </a>

  <a class="btn btn-block btn-social btn-twitter">
    <span class="fa fa-twitter"></span> Sign in with Twitter
  </a>

Might be happier if Font-Awesome removed the class social suggestion's of using the

btn-twitter
btn-facebook
btn-[....]
btn-social-icon

Then we can simply remove the specific fa-[elements] from the social list.

ryanbr commented Sep 19, 2016

Okay, didn't relise there was another open ticket..

From: ​https://lipis.github.io/bootstrap-social/


  <a class="btn btn-social-icon btn-twitter">
    <span class="fa fa-twitter"></span>
  </a>

  <a class="btn btn-block btn-social btn-twitter">
    <span class="fa fa-twitter"></span> Sign in with Twitter
  </a>

Might be happier if Font-Awesome removed the class social suggestion's of using the

btn-twitter
btn-facebook
btn-[....]
btn-social-icon

Then we can simply remove the specific fa-[elements] from the social list.

@ryanbr

This comment has been minimized.

Show comment
Hide comment
@ryanbr

ryanbr Sep 22, 2016

No response?

ryanbr commented Sep 22, 2016

No response?

@david-w

This comment has been minimized.

Show comment
Hide comment
@david-w

david-w Sep 26, 2016

@ryanbr THANK YOU for removing the generic Font Awesome social icons from the Fanboy Social List!

david-w commented Sep 26, 2016

@ryanbr THANK YOU for removing the generic Font Awesome social icons from the Fanboy Social List!

@rhanajoy

This comment has been minimized.

Show comment
Hide comment
@s1awa

This comment has been minimized.

Show comment
Hide comment
@s1awa

s1awa Oct 28, 2016

Fri, 23 Sep 2016 M: Remove font-awesome generic filters
https://hg.adblockplus.org/easylist/rev/3164f12b604f

Issue can be closed?

s1awa commented Oct 28, 2016

Fri, 23 Sep 2016 M: Remove font-awesome generic filters
https://hg.adblockplus.org/easylist/rev/3164f12b604f

Issue can be closed?

@tagliala

This comment has been minimized.

Show comment
Hide comment
@tagliala

tagliala Oct 28, 2016

Member

@MrSlawa I can confirm it is not an issue for me, let's wait some other feedback

Member

tagliala commented Oct 28, 2016

@MrSlawa I can confirm it is not an issue for me, let's wait some other feedback

@davidmiller davidmiller referenced this issue in DemocracyClub/yournextrepresentative Apr 12, 2017

Open

Adblocker flagging social login links as spam #89

@s1awa

This comment has been minimized.

Show comment
Hide comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment