Add IE7 LESS file #270

Merged
merged 2 commits into from Jun 16, 2012

Conversation

Projects
None yet
2 participants
Contributor

Synchro commented Jun 12, 2012

I thought this would happen as part of #38 but it didn't, so here's my take on it, adapted from the 2.0 release so it's got all the new icons. It reduces markup dramatically and makes it much easier to make global changes, such as removing the   suffix. I spotted I'd made an error in my code in the comments - this version works! I recompiled the IE7 CSS files using lessc -x (using lessc 1.3) in both the main library and the docs folders, though the formatting comes out a bit different to the original.

Something that had me confused for a bit is that the CSS file this generates won't work by itself in IE7 as it's missing the @font-face declaration - the IE7 styles need to be used as well as (not instead of) the original stylesheet. This means that IE7 gets sent more CSS than is strictly necessary, but then anyone using IE7 is clearly a glutton for punishment already :)

Contributor

kremalicious commented Jun 15, 2012

Awesome, thanks for that! Only caveat: the compiled main CSS shouldn't be compressed or stripped of indentations. This is for those users who use no preprocessors so readability of the code is important for easy tinkering. Compressing the docs version is a good idea though. Would it be possible for you to recompile the non-docs css without -x? And adding it as another commit here? Thanks!

Contributor

Synchro commented Jun 15, 2012

OK, I recreated the uncompressed CSS file and didn't touch the one in docs.

Contributor

kremalicious commented Jun 16, 2012

Would love to keep the formatting from the less file but realize it's not possible with the lessc compiler.

kremalicious merged commit ee55c85 into FortAwesome:master Jun 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment