New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for release 4.0.0 #42
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlwilkerson
changed the title
Determine config by admin user only
Prepare for release 4.0.0
Jul 30, 2019
mlwilkerson
added a commit
that referenced
this pull request
Jul 31, 2019
These have been prone to false negatives. Equivalent coverage is in PR #42, on its way into master soon.
mlwilkerson
added a commit
that referenced
this pull request
Jul 31, 2019
* Change REST endpoint error handling to pass on exception messages and stack traces * Modify React components in UI to display additional error output when available from the REST endpoints * Remove output matching tests These have been prone to false negatives. Equivalent coverage is in PR #42, on its way into master soon. * Improve error output in dev mode when webpack dev server is not running
- and the getter method from pseudo_elements to svg_pseudo_elements
- Never resolve latest version when reading - do not use "latest" (an unresolved version) anywhere on the back end -- simplifies error handling. - clean up some of the admin client name stuff that's no longer necessary - FontAwesome::options() now returns with actual version number, no longer @throws exception - remove options_with_resolved_version(), since version resolution will now always happen at the time of writing the options, never at read time. - Fix up some tests to make sure they run activate() as a setup step to make sure initial options are set.
...after replacing lazy loaded CSS module for Reporter with inline style object
Re-creating this PR as #58 due to changing branch name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR represents a significant overhaul, in preparation for a 4.0.0 production release. It will include:
The load configuration for Font Awesome is determined solely by the options set by the WordPress admin user.
Other themes or plugins should still register themselves using the register() method, but this registers only their preferences, not requirements.
The changes the logic of the plugin significantly, resulting in massive simplification, and also paving the way for better integration with kits.
The admin UI will indicate to the site owner when a change of preferences would result in conflict with the preferences registered by other themes or plugins.
Integration with Conflict Detection.
This will allow more surgical removal of conflicting versions of Font Awesome.
It might result in a breaking change to the current "remove unregistered clients" feature, yet to be determined.
Re-designed admin UI
satisfies()
function instead of semverFontAwesome::conflicts()
to reflect that all preference conflicts are indicated, not just the first conflictsatisfies_or_warn()
to be something likeplugin_version_satisfies_or_warn()
to disambiguate with testing Font Awesome asset version satisfaction in the preference conflict resolverremoveUnregisteredClients
option inconvert_options_from_v1()
.There's no exact equivalence between the two schemes, since the new scheme involves first enabling client-side detection, and then selecting which detected conflicts to blacklist. Probably we'll allow this to be a breaking change, and alert users upgrading that they'll need to use the new detection mechanism. We might want to put up an admin notice upon upgrade, and certainly include a note in the changelog.
version
preference as[ '5.8.2', '=' ]
(an array) instead of[[ '5.8.2', '=' ] ]
(array of arrays). Currently,FontAwesome::satisfies
throws anInvalidArgumentException
in such a case, but the admin client just ends up with an opaque500
error, which makes it seem like the plugin itself is broken, instead of showing that one of the clients is the root cause.data-fa-detection-ignore
to all elements added by this plugin
from shortcode rendering (see forum topic)script_loader_tag
is still working correctly when adding the integrity key