New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CKEditor footnotes #4419
CKEditor footnotes #4419
Conversation
Co-authored-by: jcmustin <jonathan.mustin@centreforeffectivealtruism.org>
Co-authored-by: JP Addison <johnpaddison@gmail.com>
…altruism/EAForum into ckeditor-footnotes
|
I tested this out. When I select a word, and click "add footnote", it seems to insert the footnote indicator at the beginning of the word rather than the end, which is what I'd expect and want. |
Thank you! Fixed in 940827e. |
|
Very cool! This is one of the most requested features, so I'm very glad to see this being shipped. Thanks. Thoughts:
|
That makes sense! Removed from the block toolbar in 45a1fad.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (already reviewed in old PR)
I would make sure to double check that the transpiled code is up-to-date before merging.
This PR adds footnote support to CKEditor. (Note: this PR predated Forum Magnum, and has already gone through review within CEA here.)
Footnotes can be added in two ways:
[^<number>]), which gets auto-converted to the same format as the above methodsFootnotes are indexed 1 to n. Deleting a footnote renumbers subsequent footnotes and their references. Reordering footnote references in the post reorders footnotes in the footer (s.t. the first footnote reference always has index 1).
See the README for a more thorough description of functionality and specifics about the code.