Skip to content

Conversation

@akrolsmir
Copy link
Contributor

@akrolsmir akrolsmir commented Nov 2, 2022

Directly cribbed from Manifold previews #4907.

Untested at the moment, see #6016...

┆Issue is synchronized with this Asana task by Unito
┆Link To Task: https://app.asana.com/0/1201302964208280/1203289948916147

@akrolsmir akrolsmir marked this pull request as ready for review November 2, 2022 23:42
@akrolsmir akrolsmir requested a review from a team as a code owner November 2, 2022 23:42
@akrolsmir akrolsmir requested review from Xodarap and removed request for a team November 2, 2022 23:42
@Xodarap
Copy link
Contributor

Xodarap commented Nov 5, 2022

This isn't working for me – I think it's because you fixed the typo but then didn't rebuild the source?

@akrolsmir
Copy link
Contributor Author

This isn't working for me – I think it's because you fixed the typo but then didn't rebuild the source?

Ah thanks -- rebuilt ckeditor, please take a look!

@Xodarap Xodarap merged commit 1d4684f into ForumMagnum:master Nov 8, 2022
@Xodarap Xodarap mentioned this pull request Nov 9, 2022
@Xodarap
Copy link
Contributor

Xodarap commented Nov 9, 2022

@akrolsmir thanks for doing this! It's now deployed – want to write an announcement post?

@akrolsmir
Copy link
Contributor Author

@akrolsmir thanks for doing this! It's now deployed – want to write an announcement post?

Thanks -- I'll let Nuno know and let him decide how to handle the announcement. Appreciate your help here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants