Add better explanation when a post is inaccessible #6143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpaddison3
reviewed
Nov 21, 2022
| return <Error404/> | ||
| } else if (isOperationNotAllowedError(error)) { | ||
| return <Components.ErrorAccessDenied/> | ||
| return <Components.ErrorAccessDenied explanation={"This is usually because the post in question has been removed by the author."}/> |
There was a problem hiding this comment.
Problem: sometimes we will draft infohazard posts. Then this message is misleading, albeit true. Maybe that's fine. It does say "usually".
There was a problem hiding this comment.
Hmm, I think usually does the trick here, there are lots of reasons why a post might be inaccessible and I don't think it's worth trying to explain all of them. Going to merge this for "not letting the perfect get in the way of the good" reasons
jpaddison3
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
┆Issue is synchronized with this Asana task by Unito