New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"buildInfo" is returning wrong version information #54

Closed
apkar opened this Issue Jan 29, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@apkar
Copy link
Contributor

apkar commented Jan 29, 2019

As reported here, mongo shell is returning version 2.4.0. We are compatible with 3.0.0 it should return that instead.

The issue is mongo shell depends on buildInfo command response to find out version. We are updating isMaster but not buildInfo. We should change there too.

Note: Not directly related to this, but with buildInfo we don't return anything about git hash or branch information, as we are not really MongoDB. So far, that didn't seem to cause any issues, or we didn't notice yet. We do have a custom command getdoclayerversion that gives us more information on Document Layer versions.

@apkar

This comment has been minimized.

Copy link
Contributor Author

apkar commented Jan 29, 2019

@dongxinEric

This comment has been minimized.

Copy link
Contributor

dongxinEric commented Jan 29, 2019

IMO, the version number would better be defined in some consolidated constant value header file or something like that, instead of a plain string literal. That will make the future release process much easier, when you only have to edit one/fewer files.

@apkar

This comment has been minimized.

Copy link
Contributor Author

apkar commented Jan 29, 2019

Yeah! We should maintain some kind of map between wire protocol and server version.

@apkar apkar added this to the 1.7.0 milestone Feb 14, 2019

@apkar apkar self-assigned this Feb 15, 2019

@apkar apkar added the In progress label Feb 15, 2019

dongxinEric added a commit that referenced this issue Feb 15, 2019

Merge pull request #80 from apkar/build-info
Resolved #54: "buildInfo" should report correct server version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment