Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OnlineIndexBuilder has too many constructors with too many arguments #147

Closed
MMcM opened this issue Nov 14, 2018 · 1 comment
Closed

OnlineIndexBuilder has too many constructors with too many arguments #147

MMcM opened this issue Nov 14, 2018 · 1 comment
Assignees
@MMcM

Comments

@MMcM
Copy link
Contributor

MMcM commented Nov 14, 2018

This suggests the need for an OnlineIndexBuilderBuilder, so probably also want to rename the class.

Current contender is OnlineIndexer.
@MMcM MMcM self-assigned this Nov 14, 2018
@alecgrieser
Copy link
Contributor

Is OnlineIndexRebuilderBuilder any better? I don't really think so.

alecgrieser added a commit that referenced this issue Nov 30, 2018
@alecgrieser
Merge pull request #156 from MMcM/online-indexer-builder
7e64a03 
Resolves #147: OnlineIndexBuilder has too many constructors with too many arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MMcM MMcM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MMcM @alecgrieser