Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Change spelling / spell check dictionary #129

Closed
oserban opened this issue Oct 11, 2017 · 4 comments
Closed

[Feature Request] Change spelling / spell check dictionary #129

oserban opened this issue Oct 11, 2017 · 4 comments

Comments

@oserban
Copy link
Contributor

@oserban oserban commented Oct 11, 2017

The user should be able to select the spelling dictionary

@bengotow
Copy link
Collaborator

@bengotow bengotow commented Oct 11, 2017

It's unlikely that we'll add this because the automatic detection works really well for most people once the dictionaries are downloaded - here's a bit more info: https://foundry376.zendesk.com/hc/en-us/articles/115001882532-Setting-the-spell-check-language

@bengotow bengotow changed the title Spelling dictionary [Feature Request] Change spelling / spell check dictionary Oct 11, 2017
@bengotow bengotow added the rejected label Oct 11, 2017
@neddy
Copy link

@neddy neddy commented Oct 19, 2017

My system language is set to Australian English, yet Mailspring spellcheck always defaults to US english. Is this what is supposed to happen? (MacOS 10.13, Mailspring Version 1.0.5 )

@Lazerproof
Copy link

@Lazerproof Lazerproof commented Oct 24, 2017

@bengotow The same thing here. I have Russian as default system language and English and Ukrainian as additional languages. But Mailspring checks spelling only for English.

@oserban
Copy link
Contributor Author

@oserban oserban commented Oct 24, 2017

@bengotow I think this should be reconsidered (i.e. remove the won't fix label).

I know for sure that language detection algorithms tend to fail for languages with a very similar vocabulary, but with different spellings (en-GB, en-US, en-AU and many more variations). With a short e-mail, the language detection algorithm will simply not have enough context to properly detect the language.

Personally, I would make this a minor issue, to be considered for a future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants