Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

myip.opendns queries by Mailspring #1357

Open
sud0woodo opened this issue Feb 8, 2019 · 4 comments
Open

myip.opendns queries by Mailspring #1357

sud0woodo opened this issue Feb 8, 2019 · 4 comments
Assignees
Labels

Comments

@sud0woodo
Copy link

@sud0woodo sud0woodo commented Feb 8, 2019

Operating System: Ubuntu 18.04 64-bit
Mailspring version: 1.5.5-b7939d38

While monitoring my network traffic I noticed myip.opendns[.]com queries that were polling for my external IP-address every minute or so. I tried to look for the opendns query reason in the code but the available code yielded no results. Can someone shine some light on this? I can't seem to think of a good reason to issue these queries, they do not use my primary DNS server either, these are direct queries to 208.67.222.222

@sud0woodo sud0woodo changed the title myip.opends queries by Mailspring myip.opendns queries by Mailspring Feb 8, 2019
@sud0woodo

This comment has been minimized.

Copy link
Author

@sud0woodo sud0woodo commented Feb 8, 2019

So this is probably because it is using the is-online library as stated in #660

But why every minute or so? Also this seems like a rather privacy unfriendly way, it polls for the external address everytime...

@bengotow

This comment has been minimized.

Copy link
Collaborator

@bengotow bengotow commented Feb 11, 2019

Hey! Thanks for reporting this—I think the problem is that without hitting an actual website it's not possible to tell with 100% confidence whether the network interface works, since captive networks etc. might also be blocking your access to the web. That said, it's odd that this library uses this particular service. It doesn't seem to look at the returned IP address at all...

Honestly we can probably just cut this out of the project and ping our own server to check that the app is online.

@bengotow bengotow self-assigned this Feb 11, 2019
@sud0woodo

This comment has been minimized.

Copy link
Author

@sud0woodo sud0woodo commented Feb 11, 2019

Thank you for looking into this and responding promptly!

@working-name

This comment has been minimized.

Copy link

@working-name working-name commented Dec 6, 2019

@bengotow But why ping that in the first place? It shouldn't happen until there's a problem connecting to an IMAP server. My pihole blocks captive.g.aaplimg.com and now Mailspring thinks it's offline when in fact it can connect to all configured email servers. This is a rather poorly thought-through process that doesn't seem to provide any benefits but only get in the user's way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.