ProtonMail Bridge IMAP integration#2323
Conversation
| _updateAccount = (accountId, updates: Partial<Account>) => { | ||
| Actions.updateAccount(accountId, updates); | ||
| } | ||
|
|
There was a problem hiding this comment.
Overall this looks great - I think this is a tricky setting though because for accounts that require a non-default value (Fastmail for now, maybe others too?) you should ideally set it before starting account sync. Changing it after using the account for a little while could also have strange effects, since you could end up with both Mailspring/Snoozed and CustomPrefix/Snoozed, and right now the sync engine actually "discovers" the default one first unless you go and delete it after creating the custom one.... It would also remove all your currently snoozed messages I think, which might be a little whacky.
What if we moved this setting to the "Connect an Account" screen where you enter the IMAP/SMTP credentials? I think having a "Custom Folder Prefix" option there might be a good way to surface this. (We could try to find other providers later where it needs to be set and update the per-domain template JSON that feeds that screen with defaults).
Let me know what you think!
|
This pull request has been mentioned on Mailspring Community. There might be relevant details there: https://community.getmailspring.com/t/protonmail-bridge-imap/485/2 |
|
This pull request has been mentioned on Mailspring Community. There might be relevant details there: |
|
This pull request has been mentioned on Mailspring Community. There might be relevant details there: |
|
any progress on that? |
|
Well, I assume this project is dead. RIP. |
|
@yurazinko ProtonMail is my main e-mail service. as soon as I found Mailspring I tried it out with Proton Mail and it didn't work. I've bumped the original issue in 2019 and they haven't made any relevant progress since them. That is a shame. ProtonMail is one of the most used secure mail providers. |
|
Hey folks! Thanks for all the feedback on this one - I'm going to go ahead and merge this 🎉 + make a few tweaks once it lands so that the container folder is primarily a configuration-time option (since changing it on an existing account from Preferences > Accounts could have weird side effects). |
5 participants
resolve #429 https://community.getmailspring.com/t/protonmail-bridge-imap/485
Foundry376/Mailspring-Sync#3