Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProtonMail Bridge IMAP integration #2323

Merged

Conversation

bl00mber
Copy link
Contributor

@bl00mber bl00mber commented Apr 28, 2021

_updateAccount = (accountId, updates: Partial<Account>) => {
Actions.updateAccount(accountId, updates);
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great - I think this is a tricky setting though because for accounts that require a non-default value (Fastmail for now, maybe others too?) you should ideally set it before starting account sync. Changing it after using the account for a little while could also have strange effects, since you could end up with both Mailspring/Snoozed and CustomPrefix/Snoozed, and right now the sync engine actually "discovers" the default one first unless you go and delete it after creating the custom one.... It would also remove all your currently snoozed messages I think, which might be a little whacky.

What if we moved this setting to the "Connect an Account" screen where you enter the IMAP/SMTP credentials? I think having a "Custom Folder Prefix" option there might be a good way to surface this. (We could try to find other providers later where it needs to be set and update the per-domain template JSON that feeds that screen with defaults).

Let me know what you think!

@foundry376-bot
Copy link

This pull request has been mentioned on Mailspring Community. There might be relevant details there:

https://community.getmailspring.com/t/protonmail-bridge-imap/485/2

@bl00mber bl00mber marked this pull request as draft May 1, 2021 20:18
@foundry376-bot
Copy link

This pull request has been mentioned on Mailspring Community. There might be relevant details there:

https://community.getmailspring.com/t/protonmail-new-emails-move-automatically-between-archive-and-inbox/210/11

@foundry376-bot
Copy link

This pull request has been mentioned on Mailspring Community. There might be relevant details there:

https://community.getmailspring.com/t/protonmail-all-emails-disappear-from-inbox-and-reappear-then-disappear-again/309/12

@bl00mber bl00mber marked this pull request as ready for review May 7, 2021 20:27
@yurazinko
Copy link

any progress on that?

@yurazinko
Copy link

Well, I assume this project is dead. RIP.

@delucca
Copy link

delucca commented Aug 10, 2021

@yurazinko ProtonMail is my main e-mail service. as soon as I found Mailspring I tried it out with Proton Mail and it didn't work.

I've bumped the original issue in 2019 and they haven't made any relevant progress since them.

That is a shame. ProtonMail is one of the most used secure mail providers.

@bengotow
Copy link
Collaborator

bengotow commented Sep 5, 2021

Hey folks! Thanks for all the feedback on this one - I'm going to go ahead and merge this 🎉 + make a few tweaks once it lands so that the container folder is primarily a configuration-time option (since changing it on an existing account from Preferences > Accounts could have weird side effects).

@bengotow bengotow merged commit df15844 into Foundry376:master Sep 5, 2021
@bl00mber
Copy link
Contributor Author

@bengotow there is also a second associated PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProtonMail Bridge IMAP integration
5 participants