create-keys allows for specifying an export directory#259
Merged
Foxboron merged 2 commits intoFoxboron:masterfrom Nov 16, 2023
Merged
create-keys allows for specifying an export directory#259Foxboron merged 2 commits intoFoxboron:masterfrom
create-keys allows for specifying an export directory#259Foxboron merged 2 commits intoFoxboron:masterfrom
Conversation
cosmastech
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
cosmastech
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
cosmastech
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
Owner
|
Missing some documentation in the manpage, else it looks great :) Thanks! https://github.com/Foxboron/sbctl/blob/master/docs/sbctl.8.txt#L28 |
Owner
|
Squash the two last commits together and it's fine :) Thanks! |
cosmastech
force-pushed
the
feature/issue-258_specify-export-path
branch
from
31436d4 to
c5f7129
Compare
Foxboron
approved these changes
Nov 11, 2023
Owner
|
Thanks! |
Contributor
Author
Thanks for your patience with me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To resolve #258
This allows the end-user to specify an
exportpath. Not entirely sure what the GUID is useful for, tbh, but since I didn't have a/usr/share/secureboot/directory, I was still having trouble running this command. I added the ability to specify thedatabase-pathtoo.