Feat/shiptheory #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettflorio
reviewed
Apr 23, 2021
| /** | ||
| * @typedef {Object} OrderDeskItem | ||
| * | ||
| * @property {string} id Order Desk's Internal ID # for the order item read-only |
There was a problem hiding this comment.
@ndvo As discussed, this isn't 100% tidied, but you're still working on it.
brettflorio
reviewed
Apr 23, 2021
Comment on lines
+74
to
+75
| | `FOXY_SHIPTHEORY_EMAIL` | The email used to log in to ShipTheory.| | ||
| | `FOXY_SHIPTHEORY_PASSWORD` | The password used to log in to ShipTheory.| |
There was a problem hiding this comment.
Wow. This is surprising, but apparently the only way to authenticate: https://shiptheory.com/developer/#authentication
brettflorio
reviewed
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature: