From e70d851dca72510d769a1dece415d09e7f285340 Mon Sep 17 00:00:00 2001 From: Chris Green Date: Thu, 29 Jan 2026 16:24:49 -0600 Subject: [PATCH] Quote `$GITHUB_OUTPUT` where used --- .github/actions/detect-act-env/action.yaml | 4 ++-- .github/actions/handle-fix-commit/action.yaml | 10 +++++----- .github/actions/setup-build-env/action.yaml | 4 ++-- .github/workflows/cmake-build.yaml | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/actions/detect-act-env/action.yaml b/.github/actions/detect-act-env/action.yaml index 34d4bce8f..66e6fff46 100644 --- a/.github/actions/detect-act-env/action.yaml +++ b/.github/actions/detect-act-env/action.yaml @@ -14,7 +14,7 @@ runs: ACTOR: ${{ github.actor }} run: | if [ "$ACTOR" = "nektos/act" ] || [ "${ACT:-}" = "true" ] || [ "${ACT:-}" = "1" ]; then - echo "is_act=true" >> $GITHUB_OUTPUT + echo "is_act=true" >> "$GITHUB_OUTPUT" else - echo "is_act=false" >> $GITHUB_OUTPUT + echo "is_act=false" >> "$GITHUB_OUTPUT" fi diff --git a/.github/actions/handle-fix-commit/action.yaml b/.github/actions/handle-fix-commit/action.yaml index 4a52e9ce4..62877f4cb 100644 --- a/.github/actions/handle-fix-commit/action.yaml +++ b/.github/actions/handle-fix-commit/action.yaml @@ -32,9 +32,9 @@ runs: working-directory: ${{ inputs.working-directory }} run: | if [[ -n $(git status --porcelain) ]]; then - echo "changes=true" >> $GITHUB_OUTPUT + echo "changes=true" >> "$GITHUB_OUTPUT" else - echo "changes=false" >> $GITHUB_OUTPUT + echo "changes=false" >> "$GITHUB_OUTPUT" fi - name: No changes to apply @@ -76,8 +76,8 @@ runs: if git push origin HEAD:${{ inputs.pr-info-ref }}; then echo "Push successful on attempt $i." COMMIT_SHA=$(git rev-parse HEAD) - echo "commit_sha=$COMMIT_SHA" >> $GITHUB_OUTPUT - echo "pushed=true" >> $GITHUB_OUTPUT + echo "commit_sha=$COMMIT_SHA" >> "$GITHUB_OUTPUT" + echo "pushed=true" >> "$GITHUB_OUTPUT" exit 0 fi if [ $i -eq ${{ inputs.retry-attempts }} ]; then @@ -110,7 +110,7 @@ runs: working-directory: ${{ inputs.working-directory }} run: | git diff > fix.patch - echo "patch_name=fix.patch" >> $GITHUB_OUTPUT + echo "patch_name=fix.patch" >> "$GITHUB_OUTPUT" - name: Upload patch if: steps.create_patch.outputs.patch_name diff --git a/.github/actions/setup-build-env/action.yaml b/.github/actions/setup-build-env/action.yaml index fec0e413c..e53b9c0d4 100644 --- a/.github/actions/setup-build-env/action.yaml +++ b/.github/actions/setup-build-env/action.yaml @@ -29,8 +29,8 @@ runs: mkdir -p "$GITHUB_WORKSPACE/$BUILD_PATH" # Set outputs - printf 'source-dir=%s/%s\n' "$GITHUB_WORKSPACE" "$SOURCE_PATH" >> $GITHUB_OUTPUT - printf 'build-dir=%s/%s\n' "$GITHUB_WORKSPACE" "$BUILD_PATH" >> $GITHUB_OUTPUT + printf 'source-dir=%s/%s\n' "$GITHUB_WORKSPACE" "$SOURCE_PATH" >> "$GITHUB_OUTPUT" + printf 'build-dir=%s/%s\n' "$GITHUB_WORKSPACE" "$BUILD_PATH" >> "$GITHUB_OUTPUT" echo "Source directory: $GITHUB_WORKSPACE/$SOURCE_PATH" echo "Build directory: $GITHUB_WORKSPACE/$BUILD_PATH" diff --git a/.github/workflows/cmake-build.yaml b/.github/workflows/cmake-build.yaml index 0eae9566e..1e893c5bc 100644 --- a/.github/workflows/cmake-build.yaml +++ b/.github/workflows/cmake-build.yaml @@ -209,7 +209,7 @@ jobs: - name: Extract repository name id: repo_name - run: echo "name=$(echo '${{ needs.pre-check.outputs.repo }}' | sed 's:.*/::')" >> $GITHUB_OUTPUT + run: echo "name=$(echo '${{ needs.pre-check.outputs.repo }}' | sed 's:.*/::')" >> "$GITHUB_OUTPUT" - name: Configure CMake id: configure