Resolved issue collecting userAgent on startup, and added user agent … #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parser to enable better logging of browser/platform/etc to capture
robertgates55
added a commit
that referenced
this pull request
Aug 20, 2015
Resolved issue collecting userAgent on startup, and added user agent …
Contributor
Author
|
Have run all drone tests with capture logging enabled, and this looks to work nicely. The issue before (where useragent was coming back as null) was because the captureListener was catching the "run script" event that fetches the useragent on startup; then trying to initiate capture - in most cases the capture initiation was finishing before the UA was fetched, causing the NPE. I'm not overly happy with the fix (not logging the script to capture if the call contains navigator.userAgent) but couldn't see a neater way without introducing something like isCaptureInitialised() method somewhere, which didn't feel much better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…parser to enable better logging of browser/platform/etc to capture