Skip to content

Conversation

@BenSmith-CR
Copy link

Added proxy support by adding a new system property and using it (if specified) to set the proxy capability of the browser.

Refactored as requested during first review, please let me know what else needs changing. Only tested with Chrome and Firefox as these are my only browsers

…specified) to set the proxy capability of the browser
@robertgates55
Copy link
Contributor

Yeah - that looks pretty neat to me.

Are all the 'final's that you've added good practice? Never been entirely sure so want someone else to agree.

Otherwise - once we're merged back up you'll just need to update the Command Line Interface page on the frameworkium wiki to reflect the new parameter.

@jleeh
Copy link
Contributor

jleeh commented Sep 1, 2015

All looks good.

@robertgates55: The finals are good practice, we should make sure that any variable that we use, if it isn't modified after being set or passed into a method, is declared as final.

Cheers for spotting them and changing them Ben. Going to click merge. I won't be tagging a release off the back of this, rather waiting and maybe doing a release later in the week.

jleeh added a commit that referenced this pull request Sep 1, 2015
Added proxy support by adding a new system property
@jleeh jleeh merged commit f4fce2f into master Sep 1, 2015
@BenSmith-CR
Copy link
Author

Cheers Jonny, I would like to claim credit but you have Simon to thank, he makes all the CR developers (and by extension Automated testers) use a set of Eclipse settings which do this automatically

@jleeh jleeh deleted the Adding_Proxy_Support branch September 1, 2015 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants