Skip to content

Conversation

@noronhaa
Copy link
Contributor

Implement headless execution capability for Chrome and Firefox

@ham1 ham1 changed the title Merge 'Headless' into Master Headless execution capability for Chrome and Firefox Oct 21, 2017
@ham1
Copy link
Member

ham1 commented Oct 21, 2017

Make sure we add docs and the property to the example yaml files.

@noronhaa
Copy link
Contributor Author

Added some javadocs and properties were already added to the main docs

@ham1
Copy link
Member

ham1 commented Nov 14, 2017

I'd like to upgrade to Selenium 2.7.1 and then try again with this feature, as we can no longer use DesiredCapabilities and we can use FirefoxOptions and ChromeOptions.

ANoronha and others added 4 commits December 29, 2017 14:18
- Moved isHeadless to Property
- Added headless tests to Travis
- Added @OverRide to methods which were missing it
@codecov
Copy link

codecov bot commented Dec 29, 2017

Codecov Report

Merging #79 into master will increase coverage by 0.23%.
The diff coverage is 52.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #79      +/-   ##
============================================
+ Coverage     36.58%   36.81%   +0.23%     
- Complexity      273      275       +2     
============================================
  Files            59       58       -1     
  Lines          1774     1779       +5     
  Branches        169      170       +1     
============================================
+ Hits            649      655       +6     
+ Misses         1039     1036       -3     
- Partials         86       88       +2
Impacted Files Coverage Δ Complexity Δ
...kium/core/ui/driver/drivers/LegacyFirefoxImpl.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...rkium/core/ui/driver/drivers/BrowserStackImpl.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...m/core/ui/driver/drivers/InternetExplorerImpl.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...meworkium/core/ui/driver/drivers/ElectronImpl.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...frameworkium/core/ui/driver/drivers/SauceImpl.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../frameworkium/core/ui/driver/drivers/GridImpl.java 50% <ø> (ø) 3 <0> (ø) ⬇️
...rameworkium/core/ui/driver/drivers/SafariImpl.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...a/com/frameworkium/core/ui/driver/DriverSetup.java 58.92% <100%> (+1.03%) 16 <0> (ø) ⬇️
...rameworkium/core/ui/driver/drivers/ChromeImpl.java 44.44% <20%> (-5.56%) 2 <0> (ø)
.../frameworkium/core/common/properties/Property.java 86.56% <50%> (-0.94%) 17 <3> (+2)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aa4913...64a9a23. Read the comment docs.

Added Empty.yaml with all properties listed alphabetically.
@ham1 ham1 merged commit 70fb29a into master Dec 29, 2017
@ham1 ham1 deleted the headless branch December 29, 2017 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants