chore: bump dependencies (consolidates 7 dependabot PRs)#201
Conversation
) - Spectre.Console 0.54.0 -> 0.55.2 (#181) - Spectre.Console.Cli/Cli.Testing 1.0.0-alpha.0.11 -> 0.16 (#172) - Spectre.Console.Testing 0.54.0 -> 0.55.2 (#172) - Microsoft.NET.Test.Sdk -> 18.5.1 (#180) - Verify / Verify.Xunit -> 31.12.5 (#156) - Roslynator.Analyzers 4.14.1 -> 4.15.0 (#144) - BenchmarkDotNet 0.15.5 -> 0.15.8 (#123) - xunit.runner.visualstudio 3.1.4 -> 3.1.5 (#78) Implement new IAnsiConsole.WriteAnsi(Action<AnsiWriter>) member added in Spectre.Console 0.55 on FileConsole (no-op, file output is plain text) and CompositeAnsiConsole (forwards to inner consoles). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
@claude Please review this PR |
|
Claude finished @FrankRay78's task in 1m 59s —— View job PR Review
SummarySolid dependency consolidation PR. The version bumps are mechanical and correct, and the
|
- Add FileConsoleTests.WriteAnsi_DoesNotThrow (no-op contract). - Add CompositeAnsiConsoleTests covering Write + WriteAnsi fan-out to all inner consoles via a SpyConsole. - Remove Spectre.Console.Cli and Spectre.Console.Cli.Testing from NetPace.Console.Tests — neither is referenced in any .cs file (CLAUDE.md already notes Spectre.Console.Cli was replaced). Closes the TDD gap flagged in the PR #201 review. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
@claude All good now? |
|
Claude finished @FrankRay78's task in 48s —— View job Re-review
Yes, all good.The concern from the previous review has been addressed in commit
Both follow the project's Given-When-Then structure and The Verdict: ready to merge. The only outstanding item is CI going green on the push, which the PR description already has as a pending checkbox. |
|
Claude finished @FrankRay78's task in 4m 40s —— View job Build failure fixed
Root cause
Fix applied (commit
|
Spectre.Console's ProgressRefreshThread fires on a background thread and can call Write after FileConsole has been disposed at the end of a test, crashing the test host on Linux CI with ObjectDisposedException. Add a _writeLock + _disposed guard so background writes after disposal are silently ignored. Also adds Write_AfterDispose_DoesNotThrow test to pin the behaviour. Co-authored-by: Frank Ray <FrankRay78@users.noreply.github.com>
Summary
Consolidates the 7 open dependabot chore PRs into a single branch so they can be tested together and merged in one go.
Closes #78, #123, #144, #156, #172, #180, #181.
Bumps
Code change required by Spectre.Console 0.55
IAnsiConsolegained a newWriteAnsi(Action<AnsiWriter>)method (the newSpectre.Console.Ansilibrary). The two in-repo implementers needed implementations:FileConsole.WriteAnsi— no-op (file output is plain text only, matches existingClearno-op pattern)CompositeAnsiConsole.WriteAnsi— forwards to inner consoles (matches existingWrite/Clearpattern)No other 0.55 / Verify 31 breaking changes affected this codebase.
Test plan
dotnet build— 7 projects, 0 errors, 0 warningsdotnet test— 582 tests pass (incl. all Verify snapshot tests)🤖 Generated with Claude Code