Assumption made that you're using ConnectionString[1] can break functionality #153

Closed
j4miec opened this Issue Sep 4, 2012 · 1 comment

Comments

Projects
None yet
2 participants

j4miec commented Sep 4, 2012

Regarding Massive.cs

return new DynamicModel(ConfigurationManager.ConnectionStrings[1].Name);

The above line makes a bad assumption, that you're using the second connection string defined for the application. This is usually true (First is defined in machine.config as LocalSqlServer, second is usually the one defined in your local app.config file). However, if the app has more than 1 connection string, or indeed if 2 are defined in machine.config then this breaks horribly.

Contributor

robconery commented Sep 13, 2012

It's a convenience for when people have a small app and don't specify it. Yes it can break horribly, I'm trusting the user to understand the difference.

robconery closed this Sep 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment