Additional extension methods #155

wants to merge 1 commit into


None yet

2 participants

d4dilip commented Sep 13, 2012

Added ToDataTable and AsDynamicEnumerable extension methods 

@d4dilip d4dilip Additional extension methods
Added ToDataTable and AsDynamicEnumerable extension methods 

Thanks for the patch - but there are a number of things here that I'd like you to consider:

1 - the diff is 100% different, so it's impossible for me to see what you've done
2 - you mention that you've made 2 changes, but you've made much more than that, from what I can see with the naked eye.

3 - The namespace "Voith.Cdb.Database.DBSync.Massive.SQL" will break every single installation of Massive when people go to upgrade...

... which is where I stopped.

@robconery robconery closed this Sep 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment