Marked DynamicModel as Abstract #24

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@theBoringCoder

It seems to me that users of massive shouldn't ever create instances of DynamicModel, so I marked it as abstract.

You can actually just create an instance of DynamicModel and pass it a few parameters to set the table, primary key, etc. I think it is a legitimate usage of DynamicModel - may not be appropriate to make DynamicModel abstract given this. See the README.markdown for an example of how to do this.

A good point. I somehow missed this fact when I was looking at the sample usage. Thanks, Jeet.

If this was rejected, why is DynamicModel now abstract again? Rob, did you make this change for a reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment