Paging returns incorrect results #40

Merged
merged 1 commit into from Apr 27, 2011

Conversation

Projects
None yet
3 participants

Talljoe commented Apr 26, 2011

Paging in Massive has a bug where the first page returns the correct results, but subsequent pages return n+1 results starting from the last item on the previous page. For instance, given a list of ids 1, 2, 3, 4 and a page size of 2, Massive will return:

Page 1: [1, 2]
Page 2: [2, 3, 4]
Page 3: [4]

Instead of:

Page 1: [1, 2]
Page 2: [3, 4]

See https://gist.github.com/941728 for repro scenario.

That's a rather simple fix. I hope he accepts this pull req. ;) </stalker>

robconery added a commit that referenced this pull request Apr 27, 2011

Merged pull request #40 from Talljoe/paging-bug.
Paging returns incorrect results

@robconery robconery merged commit 1faa359 into FransBouma:master Apr 27, 2011

Contributor

robconery commented Apr 27, 2011

Duh. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment