Use String.Equals() with StringComparison.OrdinalIgnoreCase instead of String.ToLower() #80

Closed
wants to merge 1 commit into from

3 participants

@justinvp

Changed use of ToLower (which is also culture-sensitive) to String.Equals with StringComparison.OrdinalIgnoreCase.

@robconery
Collaborator

Hmmm. Is this a bug?

@davidroberts63

It will be, since some database systems allow Unicode object names then culture will have to be taken into account. MySql for example allows U+0080 - U+FFFF. Not sure if String.Equals is truly needed when checking the ArgumentNames, since "order by" and "columns" are static parts of SQL.

http://dev.mysql.com/doc/refman/5.6/en/identifiers.html

@robconery
Collaborator

This was added already...

@robconery robconery closed this Sep 19, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment