Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Latest and greatest version of Massive for Oracle #93

Merged
merged 1 commit into from Oct 27, 2011

Conversation

Projects
None yet
3 participants
Contributor

mountain65 commented Oct 4, 2011

Latest and greatest version of Massive copied/pasted and then adapted for Oracle (like before), including the TryInvokeMember. Not sure if the Last/First works properly with the ROWNUM=1 added.

Richard de Zwart Latest and greatest version of Massive copied/pasted and then adapted…
… for Oracle (like before), including the TryInvokeMember. Not sure if the Last/First works properly with the ROWNUM=1 added.
aff366c

jobzky commented Oct 9, 2011

thanks for this. I'll be using this one. You may also see my refactored massive.cs file here jobzky/massive@d9598dc
I just removed redundancies, unnecessary braces, adjust naming of variables, etc. making it 428 lines instead of original 472 lines.

For example:
"if (o is ExpandoObject)" is better than this invocation "if (o.GetType() == typeof(ExpandoObject))"

Contributor

mountain65 commented Oct 10, 2011

I would advise to stay away from "syntactically improving" the code too much. It makes it harder for Rob to evaluate the diff and I've seen him comment on that quite often. Stay close to the programming style of the original author.
But I do agree that your "if (o is ExpandoObject)" reads better, although I'm not sure if it is functionally exactly the same.

@mountain65 mountain65 closed this Oct 10, 2011

@mountain65 mountain65 reopened this Oct 10, 2011

Contributor

mountain65 commented Oct 10, 2011

Sorry, keep pusing the Close button on Github, when I just want to commit my comment.

jobzky commented Oct 10, 2011

I guess some developers even have their own modified or refactored massive file based on their needs and perspective as well. They even went so far modifying the file. That's technology trend I guess. One person can write or start a program and freely expose the codes then others may just copy and modify it or even make it better but at the end of the day the credit still should belong to the original author.

@robconery robconery added a commit that referenced this pull request Oct 27, 2011

@robconery robconery Merge pull request #93 from mountain65/patch-2
Latest and greatest version of Massive for Oracle
9ab360a

@robconery robconery merged commit 9ab360a into FransBouma:master Oct 27, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment