Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose an actual SHA for pull requests as CI_PR_SHA(_SHORT). #48

Merged
merged 3 commits into from
Jul 16, 2022

Conversation

iamstarkov
Copy link
Contributor

Default CI_SHA/GITHUB_SHA is the sha of expect-to-be merge/squash/etc commit of the pull requests,
and it can be very confusing. If you mark you artifacts with it, its very hard to trace back what was the actual commit.

CI_PR_SHA is the way I solved it for my use cases and I can see im not the first one with this problem.

Fixes #30

Default CI_SHA/GITHUB_SHA is the sha of _expect-to-be_ merge/squash/etc commit of the pull requests,
and it can be very confusing. If you mark you artifacts with it, its very hard to trace back what was the actual commit.

CI_PR_SHA is the way I solved it for my use cases and I can see im not the first one with this problem.

Fixes FranzDiebold#30
@yaldram
Copy link

yaldram commented Jul 15, 2022

Can we please merge this pull request, I need my Pull requests commits as opposed to merge commits. Thanks

@FranzDiebold FranzDiebold added the enhancement New feature or request label Jul 16, 2022
@FranzDiebold FranzDiebold self-assigned this Jul 16, 2022
@FranzDiebold FranzDiebold merged commit 72510ef into FranzDiebold:primary Jul 16, 2022
@iamstarkov iamstarkov deleted the feat/CI_BASE_SHA branch July 18, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot get correct short sha for pull requests
4 participants