Remove a get_page() from pagevec_add(). #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this need a version check to work on older versions of current? |
|
Yes, thank you for catching that. I also realized that some checks I added previously only apply to head, not stable/12. I will submit PRs to fix that. |
Now that alloc_page() always returns a wired page, the get_page() is no longer needed. Note that Linux's pagevec_add() doesn't do the get_page() either. Note that drm-v5.0 does not need this change. The i915 driver was patched to manually wire pages instead, and that manual wiring became unnecessary after alloc_page() was changed.
We use a separate branch for stable/12 (and 12.0). Just make a PR against that branch and we'll take care of it. Thanks for the help! |
|
Thanks! I can cherry pick this into the other branches easily to this PR is enough. |
|
Actually, this change only applies to this branch... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.