Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add new FreeCAD Defeaturing WB #87

Closed
easyw opened this issue Jul 2, 2018 · 9 comments

Comments

@easyw
Copy link

commented Jul 2, 2018

Could I kindly request that the Defeaturing workbench would be added?
https://github.com/easyw/Defeaturing_WB

reference at FreeCAD forum here
https://forum.freecadweb.org/viewtopic.php?f=9&t=29506
https://forum.freecadweb.org/viewtopic.php?f=8&t=29453
defeaturing-wb

@luzpaz

This comment has been minimized.

Copy link
Collaborator

commented Jul 3, 2018

@yorikvanhavre green light?
@easyw Do you mind mentioning on the README that OCC7.3 is required for this to work? Also if you can tag your github repo with freecad,workbench, and addon? Thanks!

@easyw

This comment has been minimized.

Copy link
Author

commented Jul 3, 2018

@luzpaz
These tools are working with FC stable and OCC 7.2 😄
No need to have the OCC 7.3
When they will be available I will add more features to the WB.

@easyw

This comment has been minimized.

Copy link
Author

commented Jul 3, 2018

@luzpaz
I checked and the defeaturing tools are working fine also in FC0.15 and FC0.16 😸
(with some limitation on faces coming from bsplines)

@luzpaz

This comment has been minimized.

Copy link
Collaborator

commented Jul 3, 2018

@easyw Oh good to know. I haven't added a submodule before so I'm going to wait for @yorikvanhavre to take care of this 😉

@luzpaz

This comment has been minimized.

Copy link
Collaborator

commented Jul 5, 2018

@yorikvanhavre How have you been adding submodules ?

@yorikvanhavre

This comment has been minimized.

Copy link
Member

commented Jul 5, 2018

git submodule add AddonName GitAddress

If you don't supply a name, it will take the same name as the one used on github (in this case Defeaturing_WB). The git addres you find under the "clone or download" green button on github repo pages

So in this case you would do this
git pull
to make sure your repo is clean, before doing anything. Then
git submodule add Defeaturing https://github.com/easyw/Defeaturing_WB.git
then
git commit -m "Adding Defeaturing workbench"
then
git push

@easyw

This comment has been minimized.

Copy link
Author

commented Jul 7, 2018

@luzpaz
Any news?
Thx

@luzpaz luzpaz closed this in fa40b10 Jul 7, 2018
@luzpaz

This comment has been minimized.

Copy link
Collaborator

commented Jul 7, 2018

merged in fa40b10
@easyw sorry for delay, git has a learning curve 😉

@easyw

This comment has been minimized.

Copy link
Author

commented Jul 7, 2018

Thx 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.