Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.17] FEM: fixes in import and export of VTK data #1368

Closed
wants to merge 5 commits into from

Conversation

@berndhahnebach
Copy link
Contributor

commented Mar 19, 2018

  • Branch rebased on latest master git pull --rebase upstream master
  • Unit tests confirmed to pass by running ./bin/FreeCAD --run-test 0
  • Commit message is well-written

https://forum.freecadweb.org/viewtopic.php?f=18&t=27105
https://forum.freecadweb.org/viewtopic.php?f=18&t=21571&start=70#p221591

@berndhahnebach berndhahnebach force-pushed the berndhahnebach:bhbdev138 branch from b750005 to 3e7c218 Mar 19, 2018
@berndhahnebach

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2018

compileerror here bf0e714 ... It does compiles flawless on my Debian Stretch .

Does someone has an idea, or should I remove the commit ?

@sgrogan

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2018

Does someone has an idea

Travis uses Ubuntu 14.04 that has a too old version of VTK so Pipeline post processing is disabled at compile time. VTK >= 6.2 is required.

See Here:

FreeCAD/CMakeLists.txt

Lines 676 to 688 in cee5b28

set(BUILD_FEM_VTK ON)
if(${VTK_MAJOR_VERSION} LESS 6)
message( FATAL_ERROR "Found VTK version is <6, this is not compatible" )
endif()
if(${VTK_MAJOR_VERSION} EQUAL 6)
if(${VTK_MINOR_VERSION} LESS 2)
set(VTK_OPTIONS -DVTK_NO_QUAD_POLY)
endif()
if(${VTK_MINOR_VERSION} EQUAL 0)
message(WARNING "VTK equal to 6.0 cannot be used with c++11, FEM postprocessing is disabled")
set(BUILD_FEM_VTK OFF)
endif()
endif()

@berndhahnebach

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2018

ahh ... thanks, will fix it as soon as I'm on my computer ...

@berndhahnebach berndhahnebach force-pushed the berndhahnebach:bhbdev138 branch from 3e7c218 to b94f3e3 Mar 19, 2018
@berndhahnebach

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2018

@sgrogan

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2018

Fails due this commit in master dbad77b
I am on it.

@yorikvanhavre

This comment has been minimized.

Copy link
Member

commented Mar 20, 2018

It might be because cmake wasn't triggered... I wonder if the execute_process instructions shouldn't be changed by something more cmakish...

@wwmayer

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2018

Merged.

@wwmayer wwmayer closed this Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.