Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set focus to sketcher window when a new handler is activated to ensure proper handling of keys, espcially Escape. #1656

Closed

Conversation

Projects
None yet
2 participants
@mlampert
Copy link
Contributor

commented Sep 10, 2018

In this discussion we talked about the inconsistencies of pressing Escape and wmayer root caused it to which window happens to have the focus when Escape is pressed:

https://forum.freecadweb.org/viewtopic.php?f=10&t=30759

This changeset moves the focus to the sketcher window when a sketcher tool is activated so if the user presses Escape immediately (because they got the wrong tool) the tool is dismissed and not the entire sketch editor.

mlampert added some commits Sep 10, 2018

Set focus to sketcher window when a new handler is activated to ensur…
…e proper handling of keys, espcially Escape.
@wwmayer

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2018

Merged.

@wwmayer wwmayer closed this Sep 11, 2018

@mlampert mlampert deleted the mlampert:bugfix/sketcher-escape-focus branch Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.