Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[For 0.19] support QWebEngine and QWebKit refs #1937

Closed
wants to merge 13 commits into from

Conversation

@mumme74
Copy link
Contributor

commented Jan 28, 2019

This pull request implements building against QWebEngine if Qt is >= 5.7
I fallbacks to QWebkit if qt is <= 5.6

You can configure to force use QWebKit with: cmake ... -DFREECAD_USE_QWEBKIT=ON ...

This was discussed here https://forum.freecadweb.org/viewtopic.php?f=10&t=26834#p279083

I have tested it on linux Qt4.8, Qt5.12 WebEngine and Webkit
I havent tested the QWebkit part on windows or macOS, just the QWebEngine part.
(I have not yet succeded building QWebKit with Msvc2017..)

References: issue #3774, issue #2986

@yorikvanhavre

This comment has been minimized.

Copy link
Member

commented Jan 31, 2019

Maybe best to keep this for after the release... Not sure about this

@mumme74

This comment has been minimized.

Copy link
Contributor Author

commented Feb 2, 2019

Yes it should probably wait until after release.
I did a pull request as suggested by wmayer in his response in the forum thread.

Should I have waited with PR until after 0.18?
If so I didn't get that, english is not my native language...

@yorikvanhavre

This comment has been minimized.

Copy link
Member

commented Feb 2, 2019

No, no worries, you did well. I'll just add the "on hold" tag and as soon as the release is out, we merge it.
Thanks for this PR, that change will be needed sooner or later!

@yorikvanhavre yorikvanhavre changed the title support QWebEngine and QWebKit refs [For 0.19] support QWebEngine and QWebKit refs Feb 2, 2019

@yorikvanhavre yorikvanhavre added the core label Feb 26, 2019

@apeltauer

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

@mumme74 thanks for your patch. I just tried your fix on windows with qt5.12. But I got an exception. Do your have the ability to test your fix on a windows machine? I could provide a Libpack for visual studio 2017 and qt5.12. Or maybe we could debug the code together? Br Manuel

@mumme74

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2019

@mumme74 thanks for your patch. I just tried your fix on windows with qt5.12. But I got an exception. Do your have the ability to test your fix on a windows machine? I could provide a Libpack for visual studio 2017 and qt5.12. Or maybe we could debug the code together? Br Manuel

@apeltauer, thank you for testing.
Yes I can build on windows, Yes I would very much like to test with your libpack.
What does the Exception say?

@apeltauer

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2019

We started a topic in Fc Forum See
https://forum.freecadweb.org/viewtopic.php?f=4&t=34708

Maybe you can try it with the Libpack. I got an exception when running the start workbench.
Ich will test again on Monday and will tell you the exact location...

@apeltauer

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

Your modifications works with Qt5.12 on windows 10. In my case it was not working during missing files from Qt.

@wwmayer

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2019

Merged.

@wwmayer wwmayer closed this Mar 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.