Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[For v0.19] New draft edit tool for multiple object editing and with all modifiers #1975
This is the in-progress PR of creating a new, refactored, edit tool that:
When complete I am hoping for the current draft edit tool to be deprecated.
Discussion thread: https://forum.freecadweb.org/viewtopic.php?f=23&t=34114
Thank you for creating a pull request to contribute to FreeCAD! To ease integration, please confirm the following:
And please remember to update the Wiki with the features added or changed once this PR is merged.
* It allows you to select multiple objects to edit instead of just one. * It highlights the object lines and the points in red. * It stays in the mode and allows you to run other modifiers. * A very hackish hook into the move modifier is added as a proof of concept.
PR updated for "move" tool support.
Please watch the video demo below, it shows:
This will make the "stretch" tool and the node move tool for wires and lines obsolete (though not for beziers, arcs, and other special shapes).
The last commit basically rounds out this PR in terms of implementing features. It is now possible to:
There is more polish which can be done (in particular, the scale UI code, which is special), as well as more features to be added (array subelements? offset subelements? etc), but I think this is a good stopping point for this PR as it covers move/rotate/scale. Ideally I'd like to wait until v0.18 gets released, merge this PR, do some heavy-testing as well as with @carlopav 's code, continue cleaning, and then do more PRs to polish/extend this "subelement editing" concept.
What do you reckon?
Okay just gave it a test run now. Nice!! It needs some more work as it fails in a number of cases without warning, for ex. if you select an obj that is not a wire or line. But it doesn't modify the existing behaviour if you don't use the new option, so I think there is no problem in having it merged already...
On Wed, May 08, 2019 at 07:54:54AM -0700, Yorik van Havre wrote: Okay just gave it a test run now. Nice!! It needs some more work as it fails in a number of cases without warning, for ex. if you select an obj that is not a wire or line.
Cheers :) Perhaps you can file bugs and issue them to me and I can fix them as you discover them?…
-- Dion Moult