Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddonManager: Tweak UI to return friendlier HTML formatted responses #2605

Merged
merged 3 commits into from Oct 21, 2019

Conversation

@luzpaz
Copy link
Contributor

luzpaz commented Oct 10, 2019

Using the Obsolete addons to test this on

@luzpaz

This comment has been minimized.

Copy link
Contributor Author

luzpaz commented Oct 10, 2019

@luzpaz luzpaz force-pushed the luzpaz:AddonManager-UI-tweak branch from 9eed122 to 9e396c3 Oct 10, 2019
@luzpaz luzpaz changed the title AddonManager: Tweak UI to return friendlier HTML formatted responses [WIP] AddonManager: Tweak UI to return friendlier HTML formatted responses Oct 10, 2019
@luzpaz

This comment has been minimized.

Copy link
Contributor Author

luzpaz commented Oct 10, 2019

FC-Addon-Manager-Banner-installed
FC-Addon-Manager-Banner-pending

@luzpaz luzpaz force-pushed the luzpaz:AddonManager-UI-tweak branch from 9e396c3 to 7f88f02 Oct 11, 2019
@luzpaz

This comment has been minimized.

Copy link
Contributor Author

luzpaz commented Oct 11, 2019

@yorikvanhavre heads up, I think I fixed a regression, see 7f88f02
Before the Addon Manager wasn't actually pulling obsolete addon's description in to the dialog. Now it does.

@luzpaz luzpaz changed the title [WIP] AddonManager: Tweak UI to return friendlier HTML formatted responses [Please Test] AddonManager: Tweak UI to return friendlier HTML formatted responses Oct 12, 2019
@yorikvanhavre

This comment has been minimized.

Copy link
Member

yorikvanhavre commented Oct 14, 2019

This looks good to me! Will wait a bit to see if anyone has issues with it, then merge

@luzpaz luzpaz force-pushed the luzpaz:AddonManager-UI-tweak branch from 96b87ef to ae52036 Oct 14, 2019
@luzpaz

This comment has been minimized.

Copy link
Contributor Author

luzpaz commented Oct 15, 2019

luzpaz added 3 commits Oct 11, 2019
Make the Addon Manager GUI friendlier by adding more color and uniformity to the UI for Addons that have a: pending-update, no-update, or are obsolete.
Variable `message` was used instead of `desc`
@luzpaz luzpaz force-pushed the luzpaz:AddonManager-UI-tweak branch from ae52036 to 0b7eed6 Oct 16, 2019
@luzpaz luzpaz changed the title [Please Test] AddonManager: Tweak UI to return friendlier HTML formatted responses AddonManager: Tweak UI to return friendlier HTML formatted responses Oct 16, 2019
@yorikvanhavre yorikvanhavre merged commit b58019c into FreeCAD:master Oct 21, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.