Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part Extrude improvements #265

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@DeepSOIC
Copy link
Contributor

DeepSOIC commented Aug 25, 2016

  1. separated Dir into Dir + Length. Added second Length, acting similarly to PartDesign Pad's two lengths mode.
    If Length is zero, the magnitude of Dir is to be used (for legacy). If Length is non-zero, only the direction of Dir is to be taken, but the magnitude is to be overridden by length. This should prove nice regarding expression support, as Length will have a unit.
  2. added ability to use edge as direction and optionally magnitude, like Part Revolve now accepts edges for axis. Along normal was made parametric, and works on wires too.
  3. Add 'Symmetric', and 'Reversed' options like PartDesign Pad has
  4. Added second taper angle for second length
  5. Redesigned task dialog to account for all this stuff.
    new_extrude_dialog_pr

Forum threads:
Plans to improve Part Extrude
Pull-request forum thread

DeepSOIC added some commits Aug 25, 2016

[breaking] Part: Revolve: fix forgotten check for reverseness of axis…
… link

I didn't know BRepAdaptor_Curve does not take shape orientation
(reverseness) into account.

The commit can break existing projects. If revolution feature was
created with axis linked to reversed edge, and angle span is not 360,
the revolution direction will now swap. The chances of this situation
are pretty low, and revolution supports axis linkage for not long yet.
So I hope it won't cause any noticeable trouble.

--DeepSOIC
PartGui: Revolve: solid checkbox automation
Solid checkbox will be checked by default, if the shape being revolved
is closed wires.
Part: Extrude: improvements
* split Dir into Dir+Length; added second Length
* support for parametric linked direction: to arbitrary edge, and to
normal
* options: reverse, symmetric
* second taper angle
* changed offset join mode for tapered extrusion on OCCT7
PartGui: Extrude: new task dialog
to account for new functionality of extrusion feature.
@wwmayer

This comment has been minimized.

Copy link
Contributor

wwmayer commented Sep 1, 2016

Merged

@wwmayer wwmayer closed this Sep 1, 2016

@DeepSOIC

This comment has been minimized.

Copy link
Contributor Author

DeepSOIC commented Sep 1, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.