[Sketcher] Constraint driving/driven status integration in dimension … #3201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0penBrain
changed the title
0penBrain
force-pushed
the
sketchDriving
branch
2 times, most recently
from
ebcdc36
to
ebf5cd4
Compare
0penBrain
changed the title
|
I see a UI regression: https://forum.freecadweb.org/viewtopic.php?f=3&t=33705&p=378107#p378107 |
…edition dialog This integrates the ability to manage dimensional constraint driving/driven status in the constraint edition dialog box. It adds a checkbox in the dialog to show/select whether a constraint is driving or driven. When the constraint value is modified, it is automatically set as driving. Main focus is to allow to edit name (alias) of reference (driven) constraints directly in the constraint edition box. Resolves FreeCAD#3793, FreeCAD#3978
0penBrain
force-pushed
the
sketchDriving
branch
from
ebf5cd4
to
e0b2412
Compare
Can't reproduce. Everything's OK here. Code seems OK as well. |
0penBrain
commented
Mar 19, 2020
| @@ -63,11 +62,11 @@ EditDatumDialog::EditDatumDialog(Sketcher::SketchObject* pcSketch, int ConstrNbr | |||
|
|
|||
| EditDatumDialog::~EditDatumDialog(){} | |||
|
|
|||
| void EditDatumDialog::customEvent(QEvent*) | |||
| /*void EditDatumDialog::customEvent(QEvent*) | |||
| { | |||
| this->exec(); | |||
There was a problem hiding this comment.
Maintainers, please decide if it shall be deleted or leave commented out
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…edition dialog
This integrates the ability to manage dimensional constraint driving/driven status
in the constraint edition dialog box.
It adds a checkbox in the dialog to show/select whether a constraint is driving or
driven. When the constraint value is modified, it is automatically set as driving.
Main focus is to allow to edit name (alias) of reference (driven) constraints
directly in the constraint edition box.
Resolves #3793, #3978
git pull --rebase upstream master./bin/FreeCAD --run-test 0issue #<id>orfixes #<id>where<id>is the associated MantisBT issue id if one existsLinks :
https://forum.freecadweb.org/viewtopic.php?f=3&t=33705
https://forum.freecadweb.org/viewtopic.php?f=3&t=36433