Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE][Gui] Always allow dot as decimal separator in DoubleSpinBox #3256

Open
wants to merge 1 commit into
base: master
from

Conversation

@0penBrain
Copy link
Contributor

0penBrain commented Mar 24, 2020

  • Branch rebased on latest master git pull --rebase upstream master
  • Unit tests confirmed to pass by running ./bin/FreeCAD --run-test 0
  • Commit message is well-written
  • Commit message includes issue #<id> or fixes #<id> where <id> is the associated MantisBT issue id if one exists

More details in the commit message

@0penBrain 0penBrain changed the title [Gui] Always allow dot as decimal separator in DoubleSpinBox [DONOTMERGE] [Gui] Always allow dot as decimal separator in DoubleSpinBox Mar 24, 2020
…fixes 3963

 With this commit, 'dot' character is allowed as decimal point separator.
 Local separator is still allowed too.

 For consistency with QuantitySpinBox, 'dot' isn't live-converted into
 local decimal separator when typing, but is internally converted before
 validation & interpretation operations.
@0penBrain 0penBrain force-pushed the 0penBrain:spinBoxDecPoint branch from 928fce5 to 864b933 Mar 24, 2020
@0penBrain 0penBrain changed the title [DONOTMERGE] [Gui] Always allow dot as decimal separator in DoubleSpinBox [Gui] Always allow dot as decimal separator in DoubleSpinBox Mar 24, 2020
@donovaly

This comment has been minimized.

Copy link
Contributor

donovaly commented Mar 24, 2020

Wouldn't this contradict the outcome if this discussion?: https://tracker.freecadweb.org/view.php?id=3795

@donovaly

This comment has been minimized.

Copy link
Contributor

donovaly commented Mar 24, 2020

We are already feature frozen and this change would have massive influences on many Workbenches. Therefore I am opposed to these last minute changes for FC 0.19.
Instead of changing the framework we should now concentrate on updating the docs, testing, bug fixing, tooltips etc.

Let's discuss the technical things of this PR in this forum thread: https://forum.freecadweb.org/viewtopic.php?f=3&t=35927

@0penBrain 0penBrain changed the title [Gui] Always allow dot as decimal separator in DoubleSpinBox [DO NOT MERGE][Gui] Always allow dot as decimal separator in DoubleSpinBox Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.