Draft: Some fixes in upgrade function

[marioalexis84]

Related to 0004460: Draft Upgrade - Incorrect result
The reported bug is due a error in isCoplanar function, which is now fixed. For a more detailed explanation, see https://forum.freecadweb.org/viewtopic.php?f=23&t=51200&p=440821#p440821
The expected functionality in the report is out of the scope of current implementations of joinFaces and concatenate functions, which only work on flat shapes.
The bug 0004462: Upgrade from shell to solid failed - UnboundLocalError is fixed.
The bug 0004080: Draft upgrade make face fails with a sketch contatining multiple closed loops is fixed.
Now, joinFaces can deal with faces which generates internal holes when are joined.
There is a change in the Update workflow:
If multiple faces are selected, the update function converts it to a shell or compound. On the next call, if all the faces are coplanar, a single refined face is created, or, if the shell is closed, a solid is created.

There is a possible limited functionality to refine faces created on planes other than xy, yz, xz due the precision of the shapes needed in Part.makeFace

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, please confirm the following:

• Branch rebased on latest master git pull --rebase upstream master
• Unit tests confirmed to pass by running ./bin/FreeCAD --run-test 0
• Commit message is well-written
• Commit message includes issue #<id> or fixes #<id> where <id> is the associated MantisBT issue id if one exists

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.19 Changelog Forum Thread.

---

[luzpaz]

@marioalexis84 thank you for the PR.
An aside: please consider using the webhook triggers that auto-reference our bugtracker to help the devs save time.

[marioalexis84]

thanks @luzpaz , I have already modified the commit message.

[marioalexis84]

@luzpaz 0004462: Upgrade from shell to solid failed - UnboundLocalError was closed in the bug tracker, but in this PR there is a change in the makeSolid function that prevents the reported error message.

[luzpaz]

Thanks, I think the webhooks may still work on a closed ticket. But JIC, i reopened 4462 on the tracker.
Note: JFYI, by writing
Draft: Some fixes in upgrade function. bugs #0004460, #0004462
you know you are simply notating the tickets instead of closing them, right?

[marioalexis84]

Thanks, I think the webhooks may still work on a closed ticket. But JIC, i reopened 4462 on the tracker.
Note: JFYI, by writing
Draft: Some fixes in upgrade function. bugs #0004460, #0004462
you know you are simply notating the tickets instead of closing them, right?

Yes, it is clarified in the link that you gave me

[luzpaz]

Yes, it is clarified in the link that you gave me

Then in that case what is left for 4462 beside this commit ?

[marioalexis84]

I am sorry, I mistook.
Would you rather I change the commit message to something like "bug #4460, fixes #4462"?
there is also another commit to resolve the bug #4080. Do you want me to add it to this PR?

[luzpaz]

Whatever is relevant, sure. Just remember every code push triggers TravisCI.

[yorikvanhavre]

Thanks! Merging. In case the "automatic" bug closing doens't work, it's no big deal... Just close them manually ;)