Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start: fix bug when custom folder doesn't exist #4782

Merged
merged 1 commit into from May 11, 2021

Conversation

heewa
Copy link
Contributor

@heewa heewa commented May 10, 2021

A small code bug in the Start workbench causes it to fail to load in the case that there is a "custom folder" configured which doesn't exist. This change simply checks before using it, reports a warning if it doesn't, and continues loading the workbench either way.


  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum (it's a small bug fix, but I made a forum post anyway: https://forum.freecadweb.org/viewtopic.php?p=502998)
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0 (will use CI for testing. is that alright?)
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex: Draft: fix typos - fixes #0004805

Copy link
Contributor

@0penBrain 0penBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Eventually slightly better to use 'continue' instead of 'else'.

@yorikvanhavre
Copy link
Member

good catch.. Thanks!

@yorikvanhavre yorikvanhavre merged commit cfb0309 into FreeCAD:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants