Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sketch] rework the slot command #4843

Merged
merged 1 commit into from Jun 20, 2021

Conversation

donovaly
Copy link
Member

@donovaly donovaly commented Jun 8, 2021

in practical work it turned out that the slot command is not as convenient as it should because one cannot snap to a proper endpoint and one is restricted to work perpendicular to the sketch axes

This PR fixes this by setting the second snap point to the center of the second arc and removing the perpendicularity.

Benefits:

  • when you want to get the slot at a line, edge or sketch axis, set the two center points accordingly. The line does not have to be parallel to one of the sketch axes
  • when you want to define the slot using 2 points in the sketch you can do this now

Here is a screencast how it works:
KZooJ8S2lg

Forum thread: https://forum.freecadweb.org/viewtopic.php?f=17&t=59243

(The code cosmetics in this PR was kindly automatically done by MSVC.)

In practical work it turned out that the slot command is not as convenient as it should because one cannot snap to a proper endpoint and one is restricted to work perpendicular to the sketch axes

This PR fixes this by setting the second snap point to the center of the second arc and removing the perpendicularity.

Benefits:

    when you want to get the slot at a line, edge or sketch axis, set the two center points accordingly. The line does not have to be parallel to one of the sketch axes
    when you want to define the slot using 2 points in the sketch you can do this now
@abdullahtahiriyo abdullahtahiriyo merged commit 471e143 into FreeCAD:master Jun 20, 2021
@donovaly donovaly deleted the Sketch-slot-rework branch June 20, 2021 22:04
@luzpaz
Copy link
Contributor

luzpaz commented Jun 21, 2021

@donovaly just one point of feedback. Please use [Sketcher] and not [Sketch] in your PRs for Sketcher workbench in the future. It makes it easier for us to grep the git log accurately. Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants