Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEM] Add tools for more yield points in simple hardening materials #5024

Merged
merged 3 commits into from Sep 17, 2021

Conversation

AjinkyaDahale
Copy link
Contributor

@AjinkyaDahale AjinkyaDahale commented Sep 12, 2021

String List instead of String should allow for arbitrarily many entries,
theoretically.

Note the defaults previously in YieldPoint1 an YieldPoint2 were arbitrary.
Now the list is kept empty by default.

Fixes issue #4720.


Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum: see https://forum.freecadweb.org/viewtopic.php?f=18&t=57382.
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex: Draft: fix typos - fixes #0004805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.


@luzpaz luzpaz added the WB FEM Related to the FEM Workbench label Sep 12, 2021
String List instead of String should allow for arbitrarily many entries,
theoretically.

Note the defaults previously in `YieldPoint1` an `YieldPoint2` were arbitrary.
Now the list is kept empty by default.

Fixes issue FreeCAD#4720.
Prior to a recent commit (or this, if squashed), yield points of a non-linear
material with simple hardening were stored as three different properties. These
changes consolidate them into the new `YieldPoints` property.
@berndhahnebach
Copy link
Contributor

@berndhahnebach berndhahnebach merged commit 421ece9 into FreeCAD:master Sep 17, 2021
@AjinkyaDahale AjinkyaDahale deleted the more-yield-points-fem branch September 17, 2021 14:24
@luzpaz
Copy link
Contributor

luzpaz commented Sep 17, 2021

please mention in https://wiki.freecadweb.org/Release_notes_0.20

@AjinkyaDahale
Copy link
Contributor Author

please mention in https://wiki.freecadweb.org/Release_notes_0.20

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB FEM Related to the FEM Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants