Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spreadsheet] add preference page and 3 import/export parameters #5073

Merged
merged 1 commit into from Sep 28, 2021

Conversation

mwganson
Copy link
Contributor

Creates preference page and adds 3 new import/export parameters for the delimiter, escape character, and the quote character.

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex: Draft: fix typos - fixes #0004805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.


@freecadci
Copy link

@chennes chennes merged commit 217db02 into FreeCAD:master Sep 28, 2021
@chennes
Copy link
Member

chennes commented Sep 28, 2021

We should probably add to our ToDo list tweaking this new preferences page so that it matches our others, the style isn't quite the same. But no sense holding up the merge of this feature on that detail, hopefully we can get some more testing on it now.

@mwganson mwganson deleted the spreadsheet2 branch October 1, 2021 19:48
@donovaly
Copy link
Member

donovaly commented Oct 3, 2021

And please remember to update the Wiki with the features added or changed once this PR is merged. Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.

I found this cool new feature by chance.
Can you please the next time at least write a message to the forum if you cannot document it directly in the Wiki? Then we are aware f it and can do the documenting.
I did it now:
https://wiki.freecadweb.org/Release_notes_0.20#Spreadsheet_Workbench
and
https://wiki.freecadweb.org/Spreadsheet_Preferences

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants