Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TD]prevent touched but must be execute on DrawPage #5283

Merged
merged 2 commits into from Jan 2, 2022

Conversation

WandererFan
Copy link
Contributor

Adding a new Drawing Page leaves the Page in "touched, but must be executed state". This fix corrects that situation.

wf

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex: Draft: fix typos - fixes #0004805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.


@donovaly
Copy link
Member

donovaly commented Dec 23, 2021

Many thanks.

For information: Bernd maintains and runs now the CI computers and reported today that at the moment only master commits will be checked, not PRs. Since he is in vacation, he can probably first fix this in the first week on January.

@luzpaz
Copy link
Contributor

luzpaz commented Dec 23, 2021

Awesome to see you, @WandererFan! Welcome back! 😍

@luzpaz luzpaz added the WB TechDraw Related to the TechDraw Workbench label Dec 23, 2021
@freecadci
Copy link

pipeline status for feature branch PR_5283. Pipeline 439262777 was triggered at 851a3d6. All CI branches and pipelines.

@freecadci
Copy link

pipeline status for feature branch PR_5283. Pipeline 439855197 was triggered at 312a75e. All CI branches and pipelines.

@WandererFan WandererFan merged commit cec898c into FreeCAD:master Jan 2, 2022
@WandererFan WandererFan deleted the touchedNotExec branch January 6, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WB TechDraw Related to the TechDraw Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants