Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATH] fix #4810 #5306

Merged
merged 3 commits into from
Jan 3, 2022
Merged

[PATH] fix #4810 #5306

merged 3 commits into from
Jan 3, 2022

Conversation

sliptonic
Copy link
Member

use subprocess.Popen() to avoid executing arbitrary code

Thank you for creating a pull request to contribute to FreeCAD! To ease integration, we ask you to conform to the following items. Pull requests which don't satisfy all the items below might be rejected. If you are in doubt with any of the items below, don't hesitate to ask for help in the FreeCAD forum!

  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the FreeCAD bug tracker issue number in case a particular commit solves or is related to an existing issue on the tracker. Ex: Draft: fix typos - fixes #0004805

And please remember to update the Wiki with the features added or changed once this PR is merged.
Note: If you don't have wiki access, then please mention your contribution on the 0.20 Changelog Forum Thread.


@luzpaz luzpaz added the Mod: CAM Related to the CAM/Path Workbench label Dec 29, 2021
@luzpaz
Copy link
Contributor

luzpaz commented Dec 29, 2021

@sliptonic is it mentioned anywhere in the docs that asciidoctor is a recommended dependency for Path WB?

@freecadci
Copy link

pipeline status for feature branch PR_5306. Pipeline 439265238 was triggered at debec19. All CI branches and pipelines.

use subprocess.Popen() to avoid executing arbitrary code
@sliptonic
Copy link
Member Author

@sliptonic is it mentioned anywhere in the docs that asciidoctor is a recommended dependency for Path WB?

https://wiki.freecadweb.org/Path_Sanity#Note_an_ASCIIDOC_and_Asciidoctor

@freecadci
Copy link

pipeline status for feature branch PR_5306. Pipeline 439824097 was triggered at a65dbc6. All CI branches and pipelines.

@sliptonic sliptonic merged commit 169eb65 into FreeCAD:master Jan 3, 2022
donovaly pushed a commit that referenced this pull request Jan 3, 2022
@sliptonic sliptonic deleted the bug/4810 branch January 5, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: CAM Related to the CAM/Path Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants