New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEM] Add reference highlighting for displacement constraints #5391
Conversation
@wwmayer tagging you since you recently created the class |
36363d2
to
377cf6a
Compare
Possibly fixed the issue by adding |
310966b
to
e38a27a
Compare
Making FemGui to depend on PartDesignGui is not unproblematic because the more dependencies we add between modules the longer the build process will take. This is because the build system would have to wait for PartDesignGui to be finished before it can start with FemGui. Now when looking at the implementation of ReferenceHighlighter there is actually nothing that would forbid it to move it to the Part module. And since it does not even use any particular GUI stuff it could be even moved to Part/App. |
That thought did occur to me trying to fix the issue. Do you want to make the move yourself? Otherwise I can make a PR to precede this one.
I would vote against that, since this appears to be a very GUI-centric item and the dependency on Part/Gui already exists. |
OK I will move it to Part/Gui, then. |
Thank you. Could you also add the methods to highlight vertices? Some FEM constraints can work on vertices. |
See af868ed |
What exactly do you mean? |
Like say |
ca57ebb
to
54307e5
Compare
Ah, OK. |
I think this is ready for review apart from a few kinks, which I can add as additional commits. |
Here we go: 74fe1fa But note the code is not tested yet because I didn't have a sandbox to test it. The function getVertexColors() is supposed to accept the sub-elements Vertex, Edge, Wire and Face. So the array of string can e.g. be: {Vertex1, Vertex2, Edge4, Wire1, Face7} |
54307e5
to
4ce54ef
Compare
Thanks. Rebased.
I should be able to try it with this PR's branch.
Sounds useful, albeit I can't try it with this PR. Why are we not including Shells and Solids, though? |
Following constraints affected: `ViewProviderFemConstraint` `ViewProviderFemConstraintDisplacement` `ViewProviderFemConstraintFixed` `ViewProviderFemConstraintFluidBoundary` `ViewProviderFemConstraintForce` `ViewProviderFemConstraintHeatflux` `ViewProviderFemConstraintPressure` `ViewProviderFemConstraintSpring` `ViewProviderFemConstraintTemperature`
4ce54ef
to
01ebe76
Compare
Because shells and solids are not supported by the selection mechanism. |
Merged as ec00d35 |
Thanks. I see you made some changes in |
I have opened the project files from the examples directory without problems.
Changing the inheritance of the types shouldn't cause any problems w.r.t. existing project files because this information is not stored inside the Document.xml/GuiDocument.xml there. In case you can reproduce problems then please open a forum topic and ping me there. |
@wwmayer thanks for the reply
I sure will. So far I cannot reproduce the issue but you'll be the first to know if I do. |
This PR when ready is intended to highlight the geometries on which a particular FEM constraint is applied, when in the constraint's taskview.
Forum post: https://forum.freecadweb.org/viewtopic.php?f=18&t=65412.